Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 support #152

Open
andonov85 opened this issue Oct 27, 2021 · 18 comments
Open

Vue 3 support #152

andonov85 opened this issue Oct 27, 2021 · 18 comments
Assignees
Labels
enhancement New feature or request

Comments

@andonov85
Copy link

Hello, François-Guillaume Ribreau and thank you for the great library!

We use the library in a project that we plan to migrate to Vue 3 and the question is whether support for Vue 3 is planned in the near future?

Thanks!

@andonov85 andonov85 changed the title Vue 3 Vue 3 support Oct 27, 2021
@marclaporte
Copy link

@FGRibreau What is complexity / level of work required here? Is this something a junior developer (in my team) could help with?

Thanks!

@FGRibreau
Copy link
Owner

FGRibreau commented Nov 6, 2022

Hello @marclaporte,

Since there is already an exemple facade for vue2, I think creating a facade for vue3 should not be a big deal yes :)

I will be able to guide him once a PR is open :)

@marclaporte
Copy link

@johnsantosDev Show us what you got :-)

@johnsantosDev
Copy link

Thanks @marclaporte, on it!

@FGRibreau FGRibreau added the enhancement New feature or request label Dec 12, 2022
@marclaporte
Copy link

Change of plan (sorry)

@alvinBM is now in charge.

@marclaporte
Copy link

Closed as done! #192

Congrats @alvinBM and thank you to @FGRibreau

@FGRibreau
Copy link
Owner

@alvinBM @marclaporte @johnsantosDev Hello! Just a little update, I've indeed merged the PR but lots of things are not working (storybooks, tests, docs) on the vuejs3 package, I've started a refactor to make these parts rights and then I will create a new release.

Thanks a lot for your work!

@marclaporte
Copy link

@FGRibreau I am sending you positive thoughts on this topic :-)

@FGRibreau
Copy link
Owner

FGRibreau commented Feb 26, 2024

@marclaporte I'm deeply sorry Marc, I don't have the time right now to work on fixing all the missing things in this PR to make it mergeable in ui-predicate, maybe you have available developer bandwidth to do it (fix storybooks, tests & docs generation)?

(I can guide one of your dev asynchronously though!)

@alvinBM
Copy link
Contributor

alvinBM commented Feb 27, 2024

@marclaporte I'm deeply sorry Marc, I don't have the time right now to work on fixing all the missing things in this PR to make it mergeable in ui-predicate, maybe you have available developer bandwidth to do it (fix storybooks, tests & docs generation)?

(I can guide one of your dev asynchronously though!)

@FGRibreau , I am available to fix the various blocking points, so I'll always come back to you if necessary to move forward more quickly. THANKS

@marclaporte
Copy link

@FGRibreau Please re-open this task and assign to @alvinBM

@FGRibreau
Copy link
Owner

done @marclaporte !

@alvinBM
Copy link
Contributor

alvinBM commented Mar 18, 2024

Hello @FGRibreau,

I am in the process of fixing the problems related to the doc and the storybooks, but I am currently facing a lot of bugs and perhaps incompatibility especially with the storybooks.

I built the ui-predicate-vue3 package with vite 4.3.2 and vue 3.2.13, so I got a lot of errors related to parcelRequire used in ui-predicate-core.

I wonder if the current ui-predicate-core package is compatible with vite? Maybe you can have additional information that can help me move forward faster.

NB: For storybooks I use version 8.0.0

@FGRibreau
Copy link
Owner

FGRibreau commented Mar 18, 2024 via email

@Yannick243
Copy link
Contributor

Hello @FGRibreau,

Here is the PR that fixes the points mentioned below (fixes some bugs, updates Vue3 docs, and adds related Storybooks) #204

@marclaporte
Copy link

We can close via #204 and wait for a new version! 2.0.0?

@marclaporte
Copy link

@FGRibreau How can we help for the next step? Thanks!

@FGRibreau
Copy link
Owner

@marclaporte sorry for the delay, I'm under heavy workload currently, the 2.0 release is on my todo-list be sure I will complete it in the next weeks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants