-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3 support #152
Comments
@FGRibreau What is complexity / level of work required here? Is this something a junior developer (in my team) could help with? Thanks! |
Hello @marclaporte, Since there is already an exemple facade for vue2, I think creating a facade for vue3 should not be a big deal yes :) I will be able to guide him once a PR is open :) |
@johnsantosDev Show us what you got :-) |
Thanks @marclaporte, on it! |
Change of plan (sorry) @alvinBM is now in charge. |
Closed as done! #192 Congrats @alvinBM and thank you to @FGRibreau |
@alvinBM @marclaporte @johnsantosDev Hello! Just a little update, I've indeed merged the PR but lots of things are not working (storybooks, tests, docs) on the vuejs3 package, I've started a refactor to make these parts rights and then I will create a new release. Thanks a lot for your work! |
@FGRibreau I am sending you positive thoughts on this topic :-) |
@marclaporte I'm deeply sorry Marc, I don't have the time right now to work on fixing all the missing things in this PR to make it mergeable in ui-predicate, maybe you have available developer bandwidth to do it (fix storybooks, tests & docs generation)? (I can guide one of your dev asynchronously though!) |
@FGRibreau , I am available to fix the various blocking points, so I'll always come back to you if necessary to move forward more quickly. THANKS |
@FGRibreau Please re-open this task and assign to @alvinBM |
done @marclaporte ! |
Hello @FGRibreau, I am in the process of fixing the problems related to the doc and the storybooks, but I am currently facing a lot of bugs and perhaps incompatibility especially with the storybooks. I built the ui-predicate-vue3 package with vite 4.3.2 and vue 3.2.13, so I got a lot of errors related to parcelRequire used in I wonder if the current NB: For storybooks I use version 8.0.0 |
I wonder if the current *ui-predicate-core* package is compatible with
vite? Maybe you can have additional information that can help me move
forward faster.
It might be indeed, it's a vanilla js library (using commonjs) that needs
to be compiled for the browser so "any" builder will do :)
You can — of course — please update the current dependencies, I will
release ui-predicate-core to a new major if I detect an interface change :)
…On Mon, Mar 18, 2024 at 4:36 PM Alvin BAUMA ***@***.***> wrote:
Hello @FGRibreau <https://github.com/FGRibreau>,
I am in the process of fixing the problems related to the doc and the
storybooks, but I am currently facing a lot of bugs and perhaps
incompatibility especially with the storybooks.
I built the ui-predicate-vue3 package with vite 4.3.2 and vue 3.2.13, so I
got a lot of errors related to *parcelRequire* used in ui-predicate-core.
I wonder if the current *ui-predicate-core* package is compatible with
vite? Maybe you can have additional information that can help me move
forward faster.
NB: For storybooks I use version 8.0.0
—
Reply to this email directly, view it on GitHub
<#152 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABBWQWTCFMWH35JTMSSZK3YY4CXNAVCNFSM5G2643Q2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBQGQZDGOBRGEZQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hello @FGRibreau, Here is the PR that fixes the points mentioned below (fixes some bugs, updates Vue3 docs, and adds related Storybooks) #204 |
We can close via #204 and wait for a new version! 2.0.0? |
@FGRibreau How can we help for the next step? Thanks! |
@marclaporte sorry for the delay, I'm under heavy workload currently, the 2.0 release is on my todo-list be sure I will complete it in the next weeks :) |
Hello, François-Guillaume Ribreau and thank you for the great library!
We use the library in a project that we plan to migrate to Vue 3 and the question is whether support for Vue 3 is planned in the near future?
Thanks!
The text was updated successfully, but these errors were encountered: