Update dependencies and create DEPENDENCY-NOTES.md #265
Conversation
Dependencies are updated to their latest versions. In cases where they are not being updated to their latest versions, add a note to DEPENDENCY-NOTES.md explaining why it is not being updated. Due to changes in the eslint dependency, create an eslint config file. Remove the deprecated .eslintignore and .eslintrc files. Update jest config to use transform property instead of deprecated globals property. Create test/tsconfig.json to use with updated jest config. Update tsconfig to target ES2018 to satisfy updated typescript compiler. Minor changes to usage of commander package in app.ts. Other formatting and style changes in various typescript files in order to satisfy latest eslint rules.
There was a problem hiding this comment.
When I ran npm install, I got a bunch of warnings like this:
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@eslint/config-array@0.18.0',
npm WARN EBADENGINE required: { node: '^18.18.0 || ^20.9.0 || >=21.1.0' },
npm WARN EBADENGINE current: { node: 'v18.16.0', npm: '9.5.1' }
npm WARN EBADENGINE }
I updated the .tool-versions file to use a later version of Node 18 and that fixed it. I went ahead and pushed the change because I'm not sure if you use asdf.
I also left one comment about yaml for your consideration.
I ran this branch against US Core and compared it to output from master and there were no changes.
I'm not marking this approved or request changes -- as I want to see what your response is to that comment.
DEPENDENCY-NOTES.md
Outdated
| - `@types/node`: don't update until Node 22 is LTS version (currently Node 20). | ||
| - `chalk`: major version 5 causes problems for jest. Keep updated to latest 4.x release. | ||
| - `flat`: major version 6 is an esmodule. | ||
| - `yaml`: changes to `Document.toString()` behavior makes the comments in the config file produced by `sushi init` move around a bunch. |
There was a problem hiding this comment.
We don't use yaml for sushi init in GoFSH, do we? Assuming GoFSH does not rewrite the config, it seems to me we could update yaml.
There was a problem hiding this comment.
That's a good point! I'll see about updating it, then.
Changes to how the yaml package outputs comments do not affect the usage of this package by ExportableConfiguration.
Description:
Dependencies are updated to their latest versions. In cases where they are not being updated to their latest versions, add a note to DEPENDENCY-NOTES.md explaining why it is not being updated.
Due to changes in the eslint dependency, create an eslint config file. Remove the deprecated .eslintignore and .eslintrc files.
Update jest config to use transform property instead of deprecated globals property. Create test/tsconfig.json to use with updated jest config.
Update tsconfig to target ES2018 to satisfy updated typescript compiler.
Minor changes to usage of commander package in app.ts.
Other formatting and style changes in various typescript files in order to satisfy latest eslint rules.
Testing Instructions:
Update all installed dependencies. Confirm that tests pass and that eslint/prettier report no problems. Run GoFSH on FHIR resources to make sure that dependency updates are not causing any problems that only appear at runtime.
Related Issue:
Fixes #263