Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getInterceptedXHR() method inside browser client does not take callback as an argument #15

Closed
kood1 opened this issue Aug 9, 2014 · 1 comment
Closed

getInterceptedXHR() method inside browser client does not take callback as an argument #15

kood1 opened this issue Aug 9, 2014 · 1 comment
Assignees
@kood1

Comments

@kood1
Copy link
Member

kood1 commented Aug 9, 2014

@ransha , it looks like callback is not included as an argument to getInterceptedXHR(). This is inconsistent from Node client's getInterceptedXHR().

@JacobSheppard , do you know if this was intentional?
@kood1 kood1 self-assigned this Aug 9, 2014
kood1 added a commit to kood1/MSL that referenced this issue Aug 9, 2014
@kood1
Fix for issue FINRAOS#15
289367c 
Signed-off-by: Daniel Koo <danieljamin.koo@gmail.com>
kood1 added a commit that referenced this issue Aug 9, 2014
@kood1
Merge pull request #16 from kood1/master
659df75 
Fix for issue #15
@kood1
Copy link
Member Author

kood1 commented Aug 9, 2014

Merged in #16

@kood1 kood1 closed this as completed Aug 9, 2014
@kood1 kood1 mentioned this issue Aug 9, 2014
Closed
kood1 added a commit that referenced this issue May 31, 2015
@kood1
Fix for issue #15
7b3c891 
Signed-off-by: Daniel Koo <danieljamin.koo@gmail.com>
kood1 added a commit that referenced this issue May 31, 2015
@kood1
Merge pull request #16 from kood1/master
5130ae1 
Fix for issue #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kood1 kood1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kood1