If you use double quotes as element locator, element methods in appcontainer-driver.js fails #67
Labels
Comments
|
Mind if I starting taking a look at escaping the quotes? |
|
@seoj - please feel free to start working on this and submitting a PR! :-) Thanks! |
|
For the eval() statements, instead of using eval() I was wondering if we could try something like this: window.frames[0].$('body').append('Appended from parent'); Much safer to use than an eval() and more explicit. |
|
For now decided to simply escape the quotes. Seems like the suggestion may be more impacting. |
seoj
added a commit
to seoj/MSL
that referenced
this issue
Jan 14, 2015
msl-client-browser/ -Calls to jquery now escapes quotes before passing them to eval() function. -Added localized karma unit test for the new function -Added README.md -Fixed warning in package.json where "repositories" should've been "repository"
kood1
pushed a commit
that referenced
this issue
May 31, 2015
msl-client-browser/ -Calls to jquery now escapes quotes before passing them to eval() function. -Added localized karma unit test for the new function -Added README.md -Fixed warning in package.json where "repositories" should've been "repository"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When getting element via locator, if you use double quotes the method fails to return the object since we are not escaping double quotes. We can either make it a requirement to use single quote or handle double quotes.
The text was updated successfully, but these errors were encountered: