fix bug of block notify #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sider detected 1 warning on analyzing the commit c61edbf.
We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring If you have problems or questions still, feel free to ask us via chat. 💬 You can turn off this notification if you don't want to receive it from now on. |
ghost
reviewed
Dec 17, 2020
| @@ -230,7 +229,7 @@ def resolve_promise(resolve, reject): | |||
| def make_channel_rpc_request(self, method, params, packet_type=ChannelPack.TYPE_RPC, | |||
| response_type=ChannelPack.TYPE_RPC): | |||
| rpc_data = self.encode_rpc_request(method, params) | |||
| self.logger.debug("request rpc_data : {}".format(rpc_data)) | |||
| #self.logger.debug("request rpc_data : {}".format(rpc_data)) | |||
There was a problem hiding this comment.
[Flake8] block comment should start with '# ' (view)
| Rule |
|---|
E265 |
You can close this issue if no need to fix it. Learn more.
| @@ -270,7 +269,7 @@ def onResponse(self, responsepack): | |||
| # get onResponse emitter | |||
| onresponse_emitter = ChannelHandler.getEmitterStr(self.onResponsePrefix, | |||
| responsepack.seq, responsepack.type) | |||
| if onresponse_emitter in self.requests: | |||
| if onresponse_emitter in self.requests and responsepack.type != ChannelPack.TYPE_TX_BLOCKNUM: | |||
There was a problem hiding this comment.
[Flake8] line too long (101 > 100 characters) (view)
| Rule |
|---|
E501 |
You can close this issue if no need to fix it. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.