add readEOS flag to BlobReader and BlobIO so that EOF read logic work… #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s like FileIO, the isEOF method only returns true after a read operation that returns an EOF condition
|
Note that this is my first patch, CLA is here: FLIF-hub/FLIF-CLAs#22 |
lehitoskin
reviewed
Jul 7, 2019
| { | ||
| } | ||
|
|
||
| bool isEOF() const { | ||
| return seek_pos >= data_array_size; | ||
| if(readEOS) { |
There was a problem hiding this comment.
This can be simplified to return readEOS;
There was a problem hiding this comment.
Yes, but the form you describe makes it more difficult to actually debug the code when a developer wants to set a breakpoint that would get hit only in the EOF returns true case. By actually writing out the if block, the code can then be debugged with a breakpoint as is.
There was a problem hiding this comment.
Note that most debuggers like gdb let you set conditional breakpoints for this purpose.
lehitoskin
reviewed
Jul 7, 2019
| @@ -200,14 +214,20 @@ class BlobIO | |||
| // nothing to do | |||
| } | |||
| bool isEOF() const { | |||
| return seek_pos >= bytes_used; | |||
| if(readEOS) { | |||
There was a problem hiding this comment.
This could also be simplified (identical to line 94).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s like FileIO, the isEOF method only returns true after a read operation that returns an EOF condition