Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestCafe Integration Tests #244

Merged
merged 4 commits into from
Oct 4, 2019
Merged

TestCafe Integration Tests #244

merged 4 commits into from
Oct 4, 2019

Conversation

slowr
Copy link
Member

@slowr slowr commented Sep 29, 2019

Description of PR

Introduce TestCafe integration tests on CI.

What component(s) does this PR affect?

  • Back-End (Database, Microservices, Containers, etc)
  • Front-End (Flask, API, etc)
  • Docs
  • Build System

Does the PR require changes on other components? If yes, please mark the components:

  • Back-End (Database, Microservices, Containers, etc)
  • Front-End (Flask, API, etc)
  • Docs
  • Build System

Related Issue

Resolves #

Solution

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • None of the above

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.

@slowr slowr self-assigned this Sep 29, 2019
@slowr
Copy link
Member Author

slowr commented Sep 29, 2019

To run these test you can run with:

docker run -v ${PWD}/testcafe:/tests --net=host -it testcafe/testcafe chromium:headless /tests/**/*.js

Planing to integrate it with SemaphoreCI. We should run the whole platform in test mode and then run these tests. @vkotronis Do you think we should have a global test docker compose instead of seperate like we have in backed?

@vkotronis
Copy link
Member

To run these test you can run with:

docker run -v ${PWD}/testcafe:/tests --net=host -it testcafe/testcafe chromium:headless /tests/**/*.js

Planing to integrate it with SemaphoreCI. We should run the whole platform in test mode and then run these tests. @vkotronis Do you think we should have a global test docker compose instead of seperate like we have in backed?

@slowr let's have separate for now (as with backend). We can test the frontend and the backend separately that way (if it makes sense).

Fixed nginx ports for semaphore support

More sleep time
@vkotronis vkotronis added this to the release-1.3.1 milestone Oct 2, 2019
@slowr slowr marked this pull request as ready for review October 2, 2019 22:37
Copy link
Member

@vkotronis vkotronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update the changelog, ready to merge on my side.

@slowr
Copy link
Member Author

slowr commented Oct 3, 2019

🏃 Benchmark Results 🏃

  • BGP Updates (updates/sec): 1285
  • Hijacks Detected (hijacks/sec): 92

@vkotronis vkotronis merged commit 240fb2c into master Oct 4, 2019
@vkotronis vkotronis deleted the TestCafe branch October 4, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants