Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selenium tests: #231

Merged
merged 5 commits into from
Mar 3, 2017
Merged

Conversation

ankitjavalkar
Copy link
Contributor

@ankitjavalkar ankitjavalkar commented Feb 28, 2017

Fix selenium tests:
- Fix addition of answer to codemirror using selenium
- Add custom exception when selenium fails
- Add id to logout button on student interface
- Fix imports for Python3 support in load_test.py

- Fix addition of answer to codemirror using selenium
- Add custom exception when selenium fails
- Add id to logout button on student interface
- Fix imports for Python3 support in load_test.py
@ankitjavalkar
Copy link
Contributor Author

I still need to keep selenium in install_requires because of the following reason;

I get this error when selenium is not present in the install requires;
travis_without_selen1

This is not a problem with the module load_test, that file is present. As you can see below I have not installed selenium in this case (this is the only difference);
travis_without_selen2

After adding the selenium to the install requires, all the modules are found properly and everything passes successfully.
travis_with_selen1

@ankitjavalkar
Copy link
Contributor Author

The tests are not passing because the Travis is pulling from the master branch of FOSSEE/online_test. Here is a local branch that is passing https://travis-ci.org/ankitjavalkar/online_test/builds/206595857

- Install dependencies from requirements and use setup.py
Modify setup.py to remove selenium from install_requires
" test on Yaksh!"
"Error:\n ".format(e))

raise SeleniumTestError()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to call raise SeleniumTestError(msg) instead of not using the message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants