Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified to look for /usr/bin/apio, or anything indicated by ICESTUDI… #87

Merged
merged 3 commits into from
Nov 2, 2016

Conversation

set-soft
Copy link
Contributor

@set-soft set-soft commented Nov 1, 2016

…O_APIO

If the system tool is found icestudio doesn't try to create a virtual env.

…O_APIO

If the system tool is found icestudio doesn't try to create a virtual env.
@Jesus89
Copy link
Member

Jesus89 commented Nov 1, 2016

Creo que en caso de que process.env.ICESTUDIO_APIO exista debería devolver esa variable

@set-soft
Copy link
Contributor Author

set-soft commented Nov 2, 2016

¿Aún cuando apunte a algo que no existe?
Actualmente primero verifica que apunte a algo existente.

@Jesus89
Copy link
Member

Jesus89 commented Nov 2, 2016

Me refiero a esta linea: 2eea812#diff-1b6670af853aed04871abb65b3ec1a45R161

Por ejemplo, en caso de que pase la variable de entorno ICESTUDIO_APIO con el valor '/usr/local/bin/apio', de existir este, devolverá siempre SYSTEM_APIO que es '/usr/bin/apio'.

@set-soft
Copy link
Contributor Author

set-soft commented Nov 2, 2016

Oops! ok, corregido

@Jesus89
Copy link
Member

Jesus89 commented Nov 2, 2016

Ok

@Jesus89 Jesus89 merged commit a224fe0 into FPGAwars:develop Nov 2, 2016
Jesus89 added a commit that referenced this pull request Nov 2, 2016
@Jesus89
Copy link
Member

Jesus89 commented Nov 2, 2016

He modificado el comportamiento del menu toolchain para que sea consistente con ambas opciones.

@s-ol
Copy link

s-ol commented Mar 10, 2019

Could it be that this has stopped working due to AppImage distribution?

On my system (ArchLinux, installed apio from AUR) it doesn't seem to detect apio and creates the virtualenv and apio folders in ~/.icestudio.

EDIT: nevermind, the default external path has been removed so it is now required to set the ICESTUDIO_APIO env to the absolute path of the system apio executable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants