Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculations for CHIME GBO #18

Merged
merged 29 commits into from
Jul 10, 2023
Merged

Calculations for CHIME GBO #18

merged 29 commits into from
Jul 10, 2023

Conversation

profxj
Copy link
Contributor

@profxj profxj commented May 30, 2023

Ingests COSMOS sandbox (a bit)
and performs a calculation for CHIME outriggers

Don't merge until the CHIME doc is complete (internal).

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@profxj profxj requested a review from tarraneh May 30, 2023 17:03
@Astronomer-Mohit
Copy link

Looks good to me!

@profxj
Copy link
Contributor Author

profxj commented Jun 5, 2023

Also need to get readthedocs working again..

Copy link
Collaborator

@tarraneh tarraneh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

astropath/cosmos.py Outdated Show resolved Hide resolved
calculations/CHIME/GBO/py/monte_carlo.py Outdated Show resolved Hide resolved
astropath/cosmos.py Outdated Show resolved Hide resolved
astropath/montecarlo.py Outdated Show resolved Hide resolved
calculations/CHIME/GBO/InspectFirstTry.ipynb Outdated Show resolved Hide resolved
calculations/CHIME/GBO/py/analysis.py Show resolved Hide resolved

def fig_cosmos_ex(frb_file:str, outfile:str, local:str,
imsize:float=60./3600):
""" Examlples of random FRBs in the COSMOS field
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examlples -> Examples

@profxj profxj merged commit 423f39b into main Jul 10, 2023
@profxj profxj deleted the chime_gbo branch July 10, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants