Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to EjectHatch #119

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Add timeout to EjectHatch #119

merged 1 commit into from
Mar 12, 2019

Conversation

KyleRAnderson
Copy link
Collaborator

@KyleRAnderson KyleRAnderson commented Mar 12, 2019

In case the elevator doesn't reach the height it needs to after being too
low to deploy a hatch, it was thought to be a good idea to add a timeout on this
raise command.

Summary of Changes

  • Add timeout of 0.75 seconds in case the lift doesn't raise (gets blocked on something) during hatch eject.

Testing Performed

Environment: Practice bot (cosmobot)
Tried the value and saw the timeout being used in places where the lift didn't rise enough.

In case the elevator doesn't reach the height it needs to after being too
low to deploy a hatch, it was thought to be a good idea to add a timeout on this
raise command.
@kevlam2706
Copy link

kevlam2706 commented Mar 12, 2019 via email

@KyleRAnderson
Copy link
Collaborator Author

@eandr127 ready for review now (tested on practice bot).

@kevlam2706
Copy link

kevlam2706 commented Mar 12, 2019 via email

Copy link
Collaborator

@ryanlarkin ryanlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal change that has been tested thoroughly on the practice bot

@KyleRAnderson KyleRAnderson merged commit 505cc7e into master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants