-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: Implement RFC8212 #3746
bgpd: Implement RFC8212 #3746
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Option needs a better name.
Other than that - LGTM.
bgpd/bgp_vty.c
Outdated
@@ -1860,6 +1878,32 @@ DEFUN (no_bgp_always_compare_med, | |||
return CMD_SUCCESS; | |||
} | |||
|
|||
|
|||
DEFUN(bgp_default_ebgp_policy_rfc8212, bgp_default_ebgp_policy_rfc8212_cmd, | |||
"bgp default-ebgp-policy-rfc8212", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a UI perspective, the RFC number isn't something everyone will have in the back of their head, so the option name (and help text) should be something more descriptive.
bgp ebgp-requires-route-maps
maybe? With Require in and out route-maps for eBGP peers (RFC8212)
as help text?
btw, for extra Brownie points you could add a line to |
Do we want a configure switch to turn this switch off? In a data center this does not make sense. |
What happens if ISP uses Frr without this option and upgrades to version which has this option? Or what do you mean by saying in data center? 🙂 |
BGP is commonly used as the routing protocol across hundreds of thousands of routers/switches in data centers. Requiring them to put routemaps on everyone of these connections is a no-go. |
Default behaviour is the same as the old behaviour, no problem there. |
Yes, there should be a switch to turn this off... This is absolutely required for "real" eBGP, between real autonomous systems, but should not be needed/wanted for DC fabrics. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6646/ This is a comment from an EXPERIMENTAL automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings:
Warnings Generated during build:Ubuntu 16.04 amd64 build: Successful with additional warnings:Debian Package lintian failed for Ubuntu 16.04 amd64 build:
Ubuntu 14.04 amd64 build: Successful with additional warnings:Debian Package lintian failed for Ubuntu 14.04 amd64 build:
Ubuntu 16.04 i386 build: Successful with additional warnings:Debian Package lintian failed for Ubuntu 16.04 i386 build:
Ubuntu 18.04 amd64 build: Successful with additional warnings:Debian Package lintian failed for Ubuntu 18.04 amd64 build:
Debian 8 amd64 build: Successful with additional warnings:Debian Package lintian failed for Debian 8 amd64 build:
Debian 9 amd64 build: Successful with additional warnings:Debian Package lintian failed for Debian 9 amd64 build:
CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base3 Static Analyzer issues remaining.See details at |
You mean should I add an additional check like |
I don't understand why we're discussing DC fabrics here. This feature is disabled by default. Nothing changes. So, for DC operators, just don't enable it. |
bgpd/bgp_vty.c
Outdated
{ | ||
VTY_DECLVAR_CONTEXT(bgp, bgp); | ||
bgp->ebgp_requires_route_map = DEFAULT_EBGP_POLICY_ENABLED; | ||
bgp_clear_all_ebgp_peers(bgp); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make sense to clear all peers here, for two reasons:
- any peer that does have in- & outbound route-maps is not affected, so we're causing a flap for no reason.
- if we have soft-reconfiguration inbound or route-refresh enabled, we can soft-clear to apply the setting without causing a flap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial version was without clearing the session. I will update it.
bgpd/bgp_vty.c
Outdated
{ | ||
VTY_DECLVAR_CONTEXT(bgp, bgp); | ||
bgp->ebgp_requires_route_map = DEFAULT_EBGP_POLICY_DISABLED; | ||
bgp_clear_all_ebgp_peers(bgp); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, the hard clear doesn't make sense. Additionally, since the effect of this change would only be to allow additional routes that were previously discarded, there is no "safety" reason to enforce any clear. We can leave that to the operator (maybe print a message about it.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, additional feedback :)
btw: we also have neighbor XXX prefix-list N in
- shouldn't that count as filter/policy too?
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6690/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings
Warnings Generated during build:Ubuntu 18.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 amd64 build:
Ubuntu 14.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 14.04 amd64 build:
Debian 8 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 8 amd64 build:
Debian 9 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 9 amd64 build:
Ubuntu 16.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 amd64 build:
Ubuntu 16.04 i386 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 i386 build:
CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base3 Static Analyzer issues remaining.See details at |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6689/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings
Warnings Generated during build:Ubuntu 14.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 14.04 amd64 build:
Debian 8 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 8 amd64 build:
Debian 9 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 9 amd64 build:
Ubuntu 16.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 amd64 build:
Ubuntu 18.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 amd64 build:
Ubuntu 16.04 i386 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 i386 build:
CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base3 Static Analyzer issues remaining.See details at |
🛑 Basic BGPD CI results: FAILUREResults table
For details, please contact louberger |
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 10 amd64 build: Failed (click for details)FreeBSD 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI003BUILD/config.status/config.statusMake failed for FreeBSD 10 amd64 build:
Ubuntu 14.04 amd64 build: Failed (click for details)Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI001BUILD/config.status/config.statusMake failed for Ubuntu 14.04 amd64 build:
Ubuntu 18.04 amd64 build: Failed (click for details)Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/U1804AMD64/config.status/config.statusMake failed for Ubuntu 18.04 amd64 build:
Ubuntu 16.04 i386 build: Failed (click for details)Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/U1604I386/config.status/config.statusMake failed for Ubuntu 16.04 i386 build:
Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI008BLD/config.status/config.statusMake failed for Debian 8 amd64 build:
Debian 9 amd64 build: Failed (click for details)Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI021BUILD/config.status/config.statusMake failed for Debian 9 amd64 build:
FreeBSD 11 amd64 build: Failed (click for details)FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI009BUILD/config.status/config.statusMake failed for FreeBSD 11 amd64 build:
OmniOS amd64 build: Failed (click for details)OmniOS amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI010BUILD/config.status/config.statusMake failed for OmniOS amd64 build:
CentOS 6 amd64 build: Failed (click for details)CentOS 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI006BUILD/config.status/config.statusMake failed for CentOS 6 amd64 build:
OpenBSD 6 amd64 build: Failed (click for details)OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI011BUILD/config.status/config.statusMake failed for OpenBSD 6 amd64 build:
NetBSD 6 amd64 build: Failed (click for details)NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI007BUILD/config.status/config.statusMake failed for NetBSD 6 amd64 build:
NetBSD 7 amd64 build: Failed (click for details)NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI012BUILD/config.status/config.statusMake failed for NetBSD 7 amd64 build:
Ubuntu 16.04 amd64 build: Failed (click for details)Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI014BUILD/config.status/config.statusMake failed for Ubuntu 16.04 amd64 build:
CentOS 7 amd64 build: Failed (click for details)CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI005BUILD/config.status/config.statusMake failed for CentOS 7 amd64 build:
Successful on other platforms
Warnings Generated during build:Checkout code: Successful with additional warningsFreeBSD 10 amd64 build: Failed (click for details)FreeBSD 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI003BUILD/config.status/config.statusMake failed for FreeBSD 10 amd64 build:
Ubuntu 14.04 amd64 build: Failed (click for details)Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI001BUILD/config.status/config.statusMake failed for Ubuntu 14.04 amd64 build:
Ubuntu 18.04 amd64 build: Failed (click for details)Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/U1804AMD64/config.status/config.statusMake failed for Ubuntu 18.04 amd64 build:
Ubuntu 16.04 i386 build: Failed (click for details)Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/U1604I386/config.status/config.statusMake failed for Ubuntu 16.04 i386 build:
Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI008BLD/config.status/config.statusMake failed for Debian 8 amd64 build:
Debian 9 amd64 build: Failed (click for details)Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI021BUILD/config.status/config.statusMake failed for Debian 9 amd64 build:
FreeBSD 11 amd64 build: Failed (click for details)FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI009BUILD/config.status/config.statusMake failed for FreeBSD 11 amd64 build:
OmniOS amd64 build: Failed (click for details)OmniOS amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI010BUILD/config.status/config.statusMake failed for OmniOS amd64 build:
CentOS 6 amd64 build: Failed (click for details)CentOS 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI006BUILD/config.status/config.statusMake failed for CentOS 6 amd64 build:
OpenBSD 6 amd64 build: Failed (click for details)OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI011BUILD/config.status/config.statusMake failed for OpenBSD 6 amd64 build:
NetBSD 6 amd64 build: Failed (click for details)NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI007BUILD/config.status/config.statusMake failed for NetBSD 6 amd64 build:
NetBSD 7 amd64 build: Failed (click for details)NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI012BUILD/config.status/config.statusMake failed for NetBSD 7 amd64 build:
Ubuntu 16.04 amd64 build: Failed (click for details)Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI014BUILD/config.status/config.statusMake failed for Ubuntu 16.04 amd64 build:
CentOS 7 amd64 build: Failed (click for details)CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6740/artifact/CI005BUILD/config.status/config.statusMake failed for CentOS 7 amd64 build:
|
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedUbuntu 14.04 amd64 build: Failed (click for details)Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI001BUILD/config.status/config.statusMake failed for Ubuntu 14.04 amd64 build:
Ubuntu 16.04 amd64 build: Failed (click for details)Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI014BUILD/config.status/config.statusMake failed for Ubuntu 16.04 amd64 build:
Ubuntu 18.04 amd64 build: Failed (click for details)Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/U1804AMD64/config.status/config.statusMake failed for Ubuntu 18.04 amd64 build:
Ubuntu 16.04 i386 build: Failed (click for details)Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/U1604I386/config.status/config.statusMake failed for Ubuntu 16.04 i386 build:
FreeBSD 11 amd64 build: Failed (click for details)FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI009BUILD/config.status/config.statusMake failed for FreeBSD 11 amd64 build:
Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI008BLD/config.status/config.statusMake failed for Debian 8 amd64 build:
NetBSD 6 amd64 build: Failed (click for details)NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI007BUILD/config.status/config.statusMake failed for NetBSD 6 amd64 build:
OmniOS amd64 build: Failed (click for details)OmniOS amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI010BUILD/config.status/config.statusMake failed for OmniOS amd64 build:
CentOS 7 amd64 build: Failed (click for details)CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI005BUILD/config.status/config.statusMake failed for CentOS 7 amd64 build:
CentOS 6 amd64 build: Failed (click for details)CentOS 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI006BUILD/config.status/config.statusMake failed for CentOS 6 amd64 build:
OpenBSD 6 amd64 build: Failed (click for details)OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI011BUILD/config.status/config.statusMake failed for OpenBSD 6 amd64 build:
FreeBSD 10 amd64 build: Failed (click for details)FreeBSD 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI003BUILD/config.status/config.statusMake failed for FreeBSD 10 amd64 build:
NetBSD 7 amd64 build: Failed (click for details)NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI012BUILD/config.status/config.statusMake failed for NetBSD 7 amd64 build:
Debian 9 amd64 build: Failed (click for details)Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI021BUILD/config.status/config.statusMake failed for Debian 9 amd64 build:
Successful on other platforms
Warnings Generated during build:Checkout code: Successful with additional warningsUbuntu 14.04 amd64 build: Failed (click for details)Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI001BUILD/config.status/config.statusMake failed for Ubuntu 14.04 amd64 build:
Ubuntu 16.04 amd64 build: Failed (click for details)Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI014BUILD/config.status/config.statusMake failed for Ubuntu 16.04 amd64 build:
Ubuntu 18.04 amd64 build: Failed (click for details)Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/U1804AMD64/config.status/config.statusMake failed for Ubuntu 18.04 amd64 build:
Ubuntu 16.04 i386 build: Failed (click for details)Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/U1604I386/config.status/config.statusMake failed for Ubuntu 16.04 i386 build:
FreeBSD 11 amd64 build: Failed (click for details)FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI009BUILD/config.status/config.statusMake failed for FreeBSD 11 amd64 build:
Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI008BLD/config.status/config.statusMake failed for Debian 8 amd64 build:
NetBSD 6 amd64 build: Failed (click for details)NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI007BUILD/config.status/config.statusMake failed for NetBSD 6 amd64 build:
OmniOS amd64 build: Failed (click for details)OmniOS amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI010BUILD/config.status/config.statusMake failed for OmniOS amd64 build:
CentOS 7 amd64 build: Failed (click for details)CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI005BUILD/config.status/config.statusMake failed for CentOS 7 amd64 build:
CentOS 6 amd64 build: Failed (click for details)CentOS 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI006BUILD/config.status/config.statusMake failed for CentOS 6 amd64 build:
OpenBSD 6 amd64 build: Failed (click for details)OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI011BUILD/config.status/config.statusMake failed for OpenBSD 6 amd64 build:
FreeBSD 10 amd64 build: Failed (click for details)FreeBSD 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI003BUILD/config.status/config.statusMake failed for FreeBSD 10 amd64 build:
NetBSD 7 amd64 build: Failed (click for details)NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI012BUILD/config.status/config.statusMake failed for NetBSD 7 amd64 build:
Debian 9 amd64 build: Failed (click for details)Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6741/artifact/CI021BUILD/config.status/config.statusMake failed for Debian 9 amd64 build:
|
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedUbuntu 16.04 i386 build: Failed (click for details)Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/U1604I386/config.status/config.statusMake failed for Ubuntu 16.04 i386 build:
FreeBSD 10 amd64 build: Failed (click for details)FreeBSD 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI003BUILD/config.status/config.statusMake failed for FreeBSD 10 amd64 build:
Ubuntu 18.04 amd64 build: Failed (click for details)Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/U1804AMD64/config.status/config.statusMake failed for Ubuntu 18.04 amd64 build:
Ubuntu 14.04 amd64 build: Failed (click for details)Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI001BUILD/config.status/config.statusMake failed for Ubuntu 14.04 amd64 build:
Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI008BLD/config.status/config.statusMake failed for Debian 8 amd64 build:
Debian 9 amd64 build: Failed (click for details)Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI021BUILD/config.status/config.statusMake failed for Debian 9 amd64 build:
OmniOS amd64 build: Failed (click for details)OmniOS amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI010BUILD/config.status/config.statusMake failed for OmniOS amd64 build:
OpenBSD 6 amd64 build: Failed (click for details)OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI011BUILD/config.status/config.statusMake failed for OpenBSD 6 amd64 build:
FreeBSD 11 amd64 build: Failed (click for details)FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI009BUILD/config.status/config.statusMake failed for FreeBSD 11 amd64 build:
NetBSD 6 amd64 build: Failed (click for details)NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI007BUILD/config.status/config.statusMake failed for NetBSD 6 amd64 build:
NetBSD 7 amd64 build: Failed (click for details)NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI012BUILD/config.status/config.statusMake failed for NetBSD 7 amd64 build:
CentOS 7 amd64 build: Failed (click for details)CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI005BUILD/config.status/config.statusMake failed for CentOS 7 amd64 build:
Ubuntu 16.04 amd64 build: Failed (click for details)Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI014BUILD/config.status/config.statusMake failed for Ubuntu 16.04 amd64 build:
CentOS 6 amd64 build: Failed (click for details)CentOS 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI006BUILD/config.status/config.statusMake failed for CentOS 6 amd64 build:
Successful on other platforms
Warnings Generated during build:Checkout code: Successful with additional warningsUbuntu 16.04 i386 build: Failed (click for details)Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/U1604I386/config.status/config.statusMake failed for Ubuntu 16.04 i386 build:
FreeBSD 10 amd64 build: Failed (click for details)FreeBSD 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI003BUILD/config.status/config.statusMake failed for FreeBSD 10 amd64 build:
Ubuntu 18.04 amd64 build: Failed (click for details)Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/U1804AMD64/config.status/config.statusMake failed for Ubuntu 18.04 amd64 build:
Ubuntu 14.04 amd64 build: Failed (click for details)Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI001BUILD/config.status/config.statusMake failed for Ubuntu 14.04 amd64 build:
Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI008BLD/config.status/config.statusMake failed for Debian 8 amd64 build:
Debian 9 amd64 build: Failed (click for details)Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI021BUILD/config.status/config.statusMake failed for Debian 9 amd64 build:
OmniOS amd64 build: Failed (click for details)OmniOS amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI010BUILD/config.status/config.statusMake failed for OmniOS amd64 build:
OpenBSD 6 amd64 build: Failed (click for details)OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI011BUILD/config.status/config.statusMake failed for OpenBSD 6 amd64 build:
FreeBSD 11 amd64 build: Failed (click for details)FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI009BUILD/config.status/config.statusMake failed for FreeBSD 11 amd64 build:
NetBSD 6 amd64 build: Failed (click for details)NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI007BUILD/config.status/config.statusMake failed for NetBSD 6 amd64 build:
NetBSD 7 amd64 build: Failed (click for details)NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI012BUILD/config.status/config.statusMake failed for NetBSD 7 amd64 build:
CentOS 7 amd64 build: Failed (click for details)CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI005BUILD/config.status/config.statusMake failed for CentOS 7 amd64 build:
Ubuntu 16.04 amd64 build: Failed (click for details)Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI014BUILD/config.status/config.statusMake failed for Ubuntu 16.04 amd64 build:
CentOS 6 amd64 build: Failed (click for details)CentOS 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6739/artifact/CI006BUILD/config.status/config.statusMake failed for CentOS 6 amd64 build:
|
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6742/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings
Warnings Generated during build:Ubuntu 16.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 amd64 build:
Ubuntu 14.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 14.04 amd64 build:
Ubuntu 16.04 i386 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 i386 build:
Ubuntu 18.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 amd64 build:
Debian 8 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 8 amd64 build:
Debian 9 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 9 amd64 build:
CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base3 Static Analyzer issues remaining.See details at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR was merged Feb 19th. FRRouting/frr#3746 FRRouting 7.0 was released March 13th. https://github.com/FRRouting/frr/releases/tag/frr-7.0
This is a fantastic step forward! Thank you! I'd like to point out that this is cannot (yet?) be considered compliance, as the feature is not enabled by default. I've updated the compliance tracker to indicate there now is a convenience configuration option. |
@ton31337 The code and functionality is merged. Check. But I cannot find any references in docs/latest mentioning the configuration option of Possible you forgot to update the docs in the process? |
Signed-off-by: Donatas Abraitis donatas.abraitis@gmail.com
Summary
Implement https://tools.ietf.org/html/rfc8212
Related Issue
#3583 (comment)
Components
bgpd