Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Remove some inconsistent local labels in check in test_ldp_vpls_topo1 #3779

Merged
merged 1 commit into from
Apr 9, 2019
Merged

tests: Remove some inconsistent local labels in check in test_ldp_vpls_topo1 #3779

merged 1 commit into from
Apr 9, 2019

Conversation

mwinter-osr
Copy link
Member

Summary

Fixes #3718.
Remove inconsistent labels from check in test_ldp_vpls_topo1

Signed-off-by: Martin Winter mwinter@opensourcerouting.org

@LabN-CI
Copy link
Collaborator

LabN-CI commented Feb 12, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/3779 f097981
Date 02/11/2019
Start 21:40:12
Finish 22:03:52
Run-Time 23:40
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-02-11-21:40:12.txt
Log autoscript-2019-02-11-21:40:54.log.bz2
Memory 479 495 429

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6687/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 8 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6687/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)
Ubuntu 14.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6687/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)
Ubuntu 16.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6687/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)
Ubuntu 18.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6687/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (2 warnings, 1 info)
Debian 9 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6687/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)
Ubuntu 16.04 i386 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6687/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

CLANG Static Analyzer Summary

  • Github Pull Request 3779, comparing to Git base SHA b7d673c

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6687/artifact/shared/static_analysis/index.html

rwestphal
rwestphal reviewed Feb 12, 2019
View reviewed changes
tests/topotests/ldp-vpls-topo1/r1/show_ldp_binding.ref
"remoteLabel":"imp-null",
"inUse":1
},
{
"addressFamily":"ipv4",
"prefix":"2.2.2.2/32",
"neighborId":"3.3.3.3",
"localLabel":"17",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this topotest can still fail with these changes since the remoteLabel of one router is the localLabel of another one (so remoteLabel is also unpredictable). I think we need to either a) stop checking the remoteLabel as well or b) only check if the local/remote labels are equal to imp-null or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwinter-osr can you please respond to this or close the PR? This review comment is getting close to 2 months old 🙂

@qlyoung qlyoung added the tests Topotests, make check, etc label Mar 26, 2019
@mwinter-osr @rwestphal
tests: test_ldp_vpls_topo1 Remove some inconsistent labels in check
97ec268 
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
rwestphal
rwestphal approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR to remove the remoteLabel checks as well (since they are also unpredictable). Checking if the "inUse" fields are correct or not should be enough for the purposes of this test.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Apr 4, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/3779 97ec268
Date 04/04/2019
Start 17:45:14
Finish 18:09:27
Run-Time 24:13
Total 1816
Pass 1816
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-04-04-17:45:14.txt
Log autoscript-2019-04-04-17:46:04.log.bz2
Memory 495 490 429

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7144/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

<TITLE>clang_check</TITLE>

clang_check

@qlyoung qlyoung merged commit c8d8450 into FRRouting:master Apr 9, 2019
@rwestphal rwestphal deleted the fix-mpls-label-topotests branch April 18, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qlyoung qlyoung qlyoung left review comments

@rwestphal rwestphal rwestphal approved these changes

Assignees
No one assigned
Labels
tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mwinter-osr @LabN-CI @NetDEF-CI @rwestphal @qlyoung