Revising the way attributes are desugared #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rpose... it does not make sense
|
Everest green too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ToSyntax, the desugaring of attributes on declarations was quite convoluted.
In the previous workflow, we would desugar the attributes first, then desugar the rest of declaration, in many cases ignoring the attributes, push the desugared decls into the environment, and then finally add the attributes back. This leads to many unexpected behaviors, e.g., a decl in the environment may not have the same attributes as the actual fully desugared decl.
This PR revises the handling of decl attributes, aiming to ensure that the attributes are handled in all cases, and that the view of the attributes of a decl in the environment is the same as the attributes on the returned, desugared declaration.
This also supports the case where attributes which may not be literally present on a declaration are computed "on the fly", e.g., by a syntax extension.