Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fstar-mode.el release matching F* release #47

Closed
catalin-hritcu opened this issue Feb 3, 2017 · 9 comments
Closed

fstar-mode.el release matching F* release #47

catalin-hritcu opened this issue Feb 3, 2017 · 9 comments

Comments

@catalin-hritcu
Copy link
Member

I'm wondering whether it would be possible to tag an fstar-mode.el release corresponding to the new F* release we did yesterday, so that people who want to use the binary package have some chance to also use a working version of the interactive mode. This would increase the value of our releases and thus motivate us to release some more :)

@s-zanella
Copy link
Contributor

That's a great idea!
At the very least, we should document which version of fstar-mode.el works with an F* release.

@catalin-hritcu
Copy link
Member Author

Did an fstar-mode.el release corresponding to F* v0.9.4.0
https://github.com/FStarLang/fstar-mode.el/releases/tag/V0.9.4.0
Hope that everyone's OK with this.

@s-zanella
Copy link
Contributor

Is the release also tagged in MELPA in some way?
How can a user of F* v0.9.4.0 download the right package using MELPA?

@s-zanella s-zanella reopened this Feb 3, 2017
@catalin-hritcu
Copy link
Member Author

No clue about Melpa. Maybe @cpitclaudel can help with that?

@cpitclaudel
Copy link
Contributor

Hi all,

Thanks Catalin for pushing a tag. Tags are automatically picked up by MELPA stable (a variant of MELPA that doesn't track projects' master branch), which means that fstar-mode is now available to users of MELPA stable (I'm not sure it was before). There are not that many users of MELPA stable, though, so all of this isn't too important.

More to the point: Emacs' package manager doesn't let you get anything but the latest version of a package; the usual approach is just to support all relevant versions in the same package. I added version detection to fstar-mode, so we should be able to handle any discrepancies between versions in there.

Are there concrete problems in fstar-mode currently (that is, are there still-in-use versions of F* that it doesn't work with?)

@s-zanella
Copy link
Contributor

Barring minor bugs, fstar-mode is currently compatible with F* master and v0.9.4.0.
I think that keeping fstar-mode compatible with the latest F* release is enough.
Having tagged versions of fstar-mode in MELPA stable for older F* releases is a nice plus.

@cpitclaudel
Copy link
Contributor

Barring minor bugs, fstar-mode is currently compatible with F* master and v0.9.4.0.

Thanks. Pointers to these (I haven't been very good at keeping up lately) would be appreciated, so I can fix them :)

@s-zanella
Copy link
Contributor

The ones I recall are #43 and #46.

cpitclaudel added a commit that referenced this issue Feb 7, 2017
This gets rid of the "non-empty prover response" warning, since it doesn't apply
anymore. Fixes #47.
cpitclaudel added a commit that referenced this issue Feb 9, 2017
This gets rid of the "non-empty prover response" warning, since it doesn't apply
anymore. Fixes #47.
@cpitclaudel
Copy link
Contributor

Ok, I think #43 and #46 are now fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants