Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #733

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Dev #733

merged 7 commits into from
Jun 17, 2024

Conversation

desht
Copy link
Contributor

@desht desht commented Jun 14, 2024

1.20.6 and the translation overhaul!

Known issue: lighting is off on quest buttons with block items. Can't track it down right now, but it is just cosmetic.

desht added 7 commits May 16, 2024 17:13
Big networking refactor!
Translations are now stored separate from other quest data, under the
lang/ folder with the quest book folder hierarchy.
Editing language can be overridden via client preference; default is
to use whatever Minecraft language is in force.
Text which doesn't have a translation in the current locale (but does
in the en_us locale) is highlighted when in edit mode.
Copy link
Member

@MichaelHillcox MichaelHillcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a fun one to review... Everything looks good to me :D

There is a couple of commented out chunks of code which can be removed if they're not needed anymore :D

@MichaelHillcox
Copy link
Member

Oh, please test dev, it looks like fabric isn't able to start

@desht desht merged commit a3c049b into main Jun 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants