-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Flora, Leveled Items, Weapons, Item locations #20
Conversation
…formation about where these items are placed in the map
Thank you for the PR, Wully! I'll take a look at it later today. |
I like the flora, lvli, and weapons exports; they're very useful. I'm not sure if the locations export is necessary because I think that map76 provides a much better way of accessing that data. What do you think? |
Does map76 provide a rest api or something to get the location data? I can only see that they just have the locations on a map I can update the PR and move the location extraction into their own files, so they are separate from the flora, lvli and weapon exports? |
Ah I see. In that case these exports would be very useful. Once you complete that 3d map, please let me know, it sounds really cool! As for the files, yes, I would appreciate it if you could separate the location code to its own file. A single file for all five types should be fine; I just think it's nice to keep the code separated. Then you could also move the associated functions that are currently in the core to that file. Any idea how large the location files will be if you export all records? |
Ok, I will move them to a seperate file along with functions for it. The location files are a bit bigger than the normal data, but not huge
|
Thanks! Those sizes look fine. I was worried that we might have to split them up like with the ID files, but these aren't much bigger than some of the others. 👍 |
Have you been able to separate the location code into a separate file? Is there anything I can help with? |
I've not had time to work on it recently, i'll close the PR for now until I sort it. Shouldn't be any trouble with it |
I have some time to work on this, so I'll see what I can do to implement these features. |
# Conflicts: # Edit scripts/ExportAll.fo76pas # Edit scripts/ExportFlatList.pas
Now serialised as JSON objects. Also fix some tiny documentation errors and such.
Awesome! The logic of your code is mostly untouched; most changes were renaming and shuffling bits of code. I've also added a few extra fields here and there. Either way, thanks very much for this PR! I've added you to the credits section of the README :) |
Nice one! Apologies I never got round to it. Well done for taking it forward! |
v2.4.0 has been released and now include the dumps from this PR |
No description provided.