-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change SHiFTCODE Source, fix universal bug and redemption output bug #54
base: master
Are you sure you want to change the base?
Conversation
Thanks for the fixes and the new Docker image! I swapped out @Fabbi's image for yours, and I'm seeing a bunch of errors when I try to run it:
I'm going to blow away the database to see if that's the issue. Anything else I can try? It looks like the HTML might contain account-specific details. If you need them to determine what's wrong, please let me know. I'll try to sanitize it to post here, or I can email you the entire output. Thanks again! |
Oh, and it eventually finishes with:
However, when I visit |
Hey mate, This looks like an error type I've not seen back from the SHiFT Redemption website. I definitely added the extra debugging (including that typo) that's outputting the returned HTML from the SHiFT Code redemption site, but from what I can tell this is an issue that would have occurred in the original (just with less verbose logging). My code isn't yet removing expired codes (I'm close to it) but at least the Are you seeing any Did you see anything different when you dropped db and retried? Can you see what the SHiFT Code Website says when you manually try to redeem |
And yeah @flammable , to have any chance of understanding that issue I think I (or someone) would need to read through the HTML that's coming back. Account details etc no issue to remove (although I don't think any sensitive passwords etc would be included). |
Sorry, been swamped! I swapped the folder (so it created fresh |
Extended the PR to handle a new Key boolean attribrite of |
Damn, I didn't realise renaming a branch would close this PR. Fixed. I'm still keen for this PR to proceed if authorised/appropriate, but in the meantime have created a new branch in my fork to document how people can consume my interim version. |
@Fabbi Hey Fabbi, have you had a chance to look at this? I've been using @ugoogalizer's Docker image for a while now and it works great (thanks!). |
Gearbox dropped a bunch of codes the other day, and this fork handled them all perfectly. Thanks! |
Hello! I'm having the same issue that flammable was having before, where the docker container would boot up, return I tried deleting the data folder, so
Thank you for keeping this project alive, and let me know if any other information would help! Full log
EDIT: Not sure what I did differently, but deleting each of the files in the data folder and running it again fixed this issue. Thank you for keeping this project alive! |
universal
keys were only actually redeemed for the first platform in the list you pass at runtime