Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events Guide #22

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Events Guide #22

merged 8 commits into from
Jan 23, 2024

Conversation

dicedpixels
Copy link
Contributor

Ports the "Events" related pages from the Wiki. I did not include the Event Index, as it's draft itself and looks very painful to maintain.

Overall, very little changed. Minor code changes to support MC 1.20.x.

@dicedpixels dicedpixels requested a review from a team as a code owner January 22, 2024 13:39
@netlify Netlify
Copy link

netlify bot commented Jan 22, 2024 •
edited
Loading

✅ Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit cc201fd
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/65afa20b426ba7000889ed17
😎 Deploy Preview https://deploy-preview-22--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IMB11
Copy link
Member

IMB11 commented Jan 22, 2024

I feel like the EventIndex can be automated, or we can just link to the fabric-api javadoc instead - dont worry much about it.

@IMB11 IMB11 added new-content A new page or set of pages stage:expansion This should be expanded labels Jan 22, 2024
modmuss50
modmuss50 reviewed Jan 22, 2024
View reviewed changes
develop/events.md Outdated Show resolved Hide resolved
develop/events.md Outdated Show resolved Hide resolved
reference/latest/src/main/java/com/example/docs/event/Events.java Outdated Show resolved Hide resolved
IMB11
IMB11 requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@IMB11 IMB11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks. See modmuss's review for the major stuff.

develop/events.md Outdated Show resolved Hide resolved
develop/events.md Outdated Show resolved Hide resolved
develop/events.md Outdated Show resolved Hide resolved
develop/events.md Outdated Show resolved Hide resolved
@IMB11 IMB11 added stage:expansion This should be expanded stage:cleanup This should be cleaned up and removed stage:expansion This should be expanded labels Jan 22, 2024
@IMB11 IMB11 mentioned this pull request Jan 22, 2024
Open
19 tasks
IMB11
IMB11 requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@IMB11 IMB11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You just need to solve the checkstyle issues 👍

@IMB11 IMB11 added stage:ready This is ready to be merged and removed stage:cleanup This should be cleaned up labels Jan 23, 2024
@IMB11 IMB11 merged commit 72941b2 into FabricMC:main Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 left review comments

@IMB11 IMB11 IMB11 approved these changes

Assignees
No one assigned
Labels
new-content A new page or set of pages stage:ready This is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dicedpixels @IMB11 @modmuss50