Read "Fabric-Loom-Remap" manifest entry to allow an artifact to control if its remapped or not. #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ol if its remapped or not. This allows for none mod jars to opt-into remapping, as well as mods or mod loaders to opt-out. Setting "Fabric-Loom-Remap" to true/false in the jar's manifest.
SquidDev
added a commit
to cc-tweaked/CC-Tweaked
that referenced
this pull request
Nov 18, 2022
- Bundle the core API inside the Fabric API jar for now, to ensure that ResourceLocation is remapped. - Add a dummy fabric.mod.json file to the API. We'll remove this once FabricMC/fabric-loom#749 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for none mod jars to opt-into remapping, as well as mods or mod loaders to opt-out. This is useful for mods that have an API jar, that isnt a real mod.
Set "Fabric-Loom-Remap" to true/false in the jar's manifest to opt-in or out. Omit this for the default (only remap mods).
Closes #717 and cleans up + tests some code.