-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest pomf #1
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But... we've already done that. Thanks anyway! |
Prospector
referenced
this pull request
in Prospector/fabric
Jun 12, 2019
Improve javadocs, rewrite SetBaseBiomesLayer mixin to support better weight mechanic, clean up VanillaLayeredBiomeSource mixin, stop accessing most fields directly, and fix formatting
shedaniel
pushed a commit
to shedaniel/fabric
that referenced
this pull request
Jul 14, 2020
shedaniel
pushed a commit
to shedaniel/fabric
that referenced
this pull request
Jul 14, 2020
buttons work
modmuss50
pushed a commit
that referenced
this pull request
Nov 5, 2020
* Resource loader for 20w45a. * You have seen nothing.
This was referenced Jul 15, 2021
ThalusA
pushed a commit
to ThalusA/fabric
that referenced
this pull request
May 31, 2022
* Resource loader for 20w45a. * You have seen nothing.
modmuss50
added a commit
that referenced
this pull request
Jun 13, 2022
* Fix loading data pack biomes * Add command to help test. * Fix custom end biomes crash closes #2292 * add plains biome to the end * remove unnecessary field prefix * End biomes now generate properly * Remove test logging * Remove test command (was barely functional) * Fix checkstyle * Some small refactors * Save the sampler directly on MultiNoiseSampler instance (#1) Co-authored-by: modmuss50 <modmuss50@gmail.com> Co-authored-by: deirn <deirn@bai.lol>
This was referenced Jul 15, 2023
modmuss50
pushed a commit
that referenced
this pull request
Jul 18, 2023
* Add API for adding custom dynamic registries Closes #1012, supersedes #1031 and #2719. * Add missing license headers * Clarify RegistryLoaderMixin namespace injection * Replace event with static registration, add skeleton for sorting registries * Fix typo * Refactor event phase sorting system for use with dynamic registries (#1) * Make minor changes to Technici4n's PR * Add test for nested dynamic objects * Revert "Add test for nested dynamic objects" This reverts commit 486e3e1. * Revert "Make minor changes to Technici4n's PR" This reverts commit 741bd52. * Revert "Refactor event phase sorting system for use with dynamic registries (#1)" This reverts commit bb7c8b8. * Remove sorting API * Add support for defaulted dynamic registries * Re-add test for nested dynamic objects * Add missing license headers * Fix typo * Remove defaulted dynamic registries; flatten registration methods * Remove last reference to registry sorting * Add option to skip syncing for empty dynregs * Update DynamicRegistrySyncOption docs Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com> * Address review feedback * Add registry namespace to tag paths for modded registries * Move dynamic registry tests into their own class for readibility * Finish DynamicRegistries doc * Only apply tag change to dynamic registries * Fix checkstyle * Update fabric-registry-sync-v0/src/main/java/net/fabricmc/fabric/api/event/registry/DynamicRegistries.java Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com> --------- Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com>
modmuss50
pushed a commit
that referenced
this pull request
Jul 18, 2023
* Add API for adding custom dynamic registries Closes #1012, supersedes #1031 and #2719. * Add missing license headers * Clarify RegistryLoaderMixin namespace injection * Replace event with static registration, add skeleton for sorting registries * Fix typo * Refactor event phase sorting system for use with dynamic registries (#1) * Make minor changes to Technici4n's PR * Add test for nested dynamic objects * Revert "Add test for nested dynamic objects" This reverts commit 486e3e1. * Revert "Make minor changes to Technici4n's PR" This reverts commit 741bd52. * Revert "Refactor event phase sorting system for use with dynamic registries (#1)" This reverts commit bb7c8b8. * Remove sorting API * Add support for defaulted dynamic registries * Re-add test for nested dynamic objects * Add missing license headers * Fix typo * Remove defaulted dynamic registries; flatten registration methods * Remove last reference to registry sorting * Add option to skip syncing for empty dynregs * Update DynamicRegistrySyncOption docs Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com> * Address review feedback * Add registry namespace to tag paths for modded registries * Move dynamic registry tests into their own class for readibility * Finish DynamicRegistries doc * Only apply tag change to dynamic registries * Fix checkstyle * Update fabric-registry-sync-v0/src/main/java/net/fabricmc/fabric/api/event/registry/DynamicRegistries.java Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com> --------- Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com> Signed-off-by: modmuss50 <modmuss50@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.