Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data picker jquery time close #1806

Merged
merged 2 commits into from
Feb 6, 2017
Merged

Conversation

pollen8
Copy link
Member

@pollen8 pollen8 commented Feb 5, 2017

mootools hide() is being suppressed in certain cases. Really thought this one had been resolved.
Might be related to this
http://fabrikar.com/forums/index.php?threads/problem-with-datetime-element-with-warp-framework.43654/
Seems sensible to use Jquery.hide instead

@cheesegrits
Copy link
Member

LOL ... I ran across example the same thing last week ...

cf4e699

@cheesegrits
Copy link
Member

BTW, will those changes to package.json bite me?

@cheesegrits cheesegrits merged commit 1a63936 into master Feb 6, 2017
@cheesegrits
Copy link
Member

And ... do you want me to delete these branches when I merge them?

Copy link
Member

@cheesegrits cheesegrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note sure about these changes to package.json?

@pollen8
Copy link
Member Author

pollen8 commented Feb 6, 2017

i couldn't install the node modules without updating the package.json.
If you don;'t npm update then it won't affect you, although it shouldn't matter even after the update.
Yeah please delete branches. I'm just doing any commit I make this way as I'm not looking at the code on a day to day basis so would prefer you vet things before they go in.

@pollen8 pollen8 deleted the data-picker-jquery-time-close branch February 6, 2017 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants