-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/(generic bufsize) #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate non-ascii character transfers (eg. binary data)
…invalid ones as bytes
Updated the PR to actually fix #43 , while also introducing a |
4 tasks
This was referenced May 29, 2020
Merged
…multiple atat instances with queues in static context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows creating ATAT instances with generic receive buffer size.
Building the
Client/IngressManager
pair throughClientBuilder
will keep the default buffer length ofU256
, but it allows specifying lengths if crated "manually" asNote This is still a bit of a work-in-progress, as i am not super happy with the API breaking it brings, though i don't think there are better ways?
It will address the part of #43 regarding
IngressManager - buf capacity
Any better ideas will be welcomed with great joy!