Remove deprecated components and deprecate non-namespaced typenames/headers #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisklein
force-pushed
the
simplification
branch
from
b779f9e
to
f247d6c
Compare
dennisklein
force-pushed
the
simplification
branch
4 times, most recently
from
642fc04
to
9dd9790
Compare
dennisklein
force-pushed
the
simplification
branch
from
d88fa78
to
96a0d42
Compare
BREAKING CHANGE: Components have been moved to ODC project, see FairRootGroup#392 for details.
For more details see FairRootGroup#423
For more details see FairRootGroup#423
BREAKING CHANGE: Removes exported targets FairMQ::Tools and FairMQ::StateMachine. However, it is unlikely those were used by anyone.
The logic of the GetNumberOfConnectedPeers test case relies on sleeping a certain time. We have observed the 10ms sleep time to sometimes be too short. Increasing it to 100ms should improve test stability.
…pmix` Camel+snake-case plugin names are still allowed! e.g. `libFairMQPlugin_pmix`
* Optimize appending another Parts container * Remove redundant/verbose comments * Change r-value args to move-only types into l-value args for readability * BREAKING CHANGE: Remove `AtRef(int)` and `AddPart(Message*)` member functions * Add various const overloads * Add `Empty()` and `Clear()` member functions * Add `noexcept` where applicable
dennisklein
force-pushed
the
simplification
branch
from
96a0d42
to
e963f13
Compare
dennisklein
force-pushed
the
simplification
branch
5 times, most recently
from
edad6ee
to
99e9bae
Compare
rbx
previously approved these changes
Apr 19, 2022
dennisklein
force-pushed
the
simplification
branch
from
99e9bae
to
acafb34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on: #392, #423
No urgency to merge. Must not be released with a
v1.4version - minimum isv1.5+.