Improve geometry state after alignment #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Set to draft as we are not sure of our fix anymore (+failed tests) |
PALoizeau
force-pushed
the
geo_assmbl_bbox_align
branch
from
4548cbb
to
d6ecf62
Compare
1. Refresh the geometry once done (needed in any case) 2. Fix for GeoAssembly bounding box having 0 dx/dy after alignment Fix could be removed once proper fix is done in Root, should not hurt if done twice
PALoizeau
force-pushed
the
geo_assmbl_bbox_align
branch
from
d6ecf62
to
563e914
Compare
|
@fuhlig1 any clue why the pipeline is failing? It seem to be stuck when trying to checkout the changes, could it be because I had not yet given the rights to access my account to |
fuhlig1
approved these changes
Dec 14, 2022
The reason of the failing builds is unclear. For me it looks like it was a problem while cloning the project. |
PALoizeau
added a commit
to PALoizeau/FairRoot
that referenced
this pull request
Apr 6, 2023
- cf discussion in root-project/root#12242 - Improvement of PR FairRootGroup#1244 - see also Issue FairRootGroup#1243 - Solves new sub-case of Cbmroot issue https://redmine.cbm.gsi.de/issues/2620 More generic solution also catching edge case where only Nodes inside assembly are aligned but not assembly itself
1 task
PALoizeau
added a commit
to PALoizeau/FairRoot
that referenced
this pull request
Apr 6, 2023
- cf discussion in root-project/root#12242 - Improvement of PR FairRootGroup#1244 - see also Issue FairRootGroup#1243 - Solves new sub-case of Cbmroot issue https://redmine.cbm.gsi.de/issues/2620 More generic solution also catching edge case where only Nodes inside assembly are aligned but not assembly itself
PALoizeau
added a commit
to PALoizeau/FairRoot
that referenced
this pull request
Apr 11, 2023
- cf discussion in root-project/root#12242 - Improvement of PR FairRootGroup#1244 - see also Issue FairRootGroup#1243 - Solves new sub-case of Cbmroot issue https://redmine.cbm.gsi.de/issues/2620 More generic solution also catching edge case where only Nodes inside assembly are aligned but not assembly itself
fuhlig1
pushed a commit
to fuhlig1/FairRoot
that referenced
this pull request
Sep 1, 2023
- cf discussion in root-project/root#12242 - Improvement of PR FairRootGroup#1244 - see also Issue FairRootGroup#1243 - Solves new sub-case of Cbmroot issue https://redmine.cbm.gsi.de/issues/2620 More generic solution also catching edge case where only Nodes inside assembly are aligned but not assembly itself (cherry picked from commit b4b5f0e)
1 task
fuhlig1
pushed a commit
to fuhlig1/FairRoot
that referenced
this pull request
Sep 6, 2023
- cf discussion in root-project/root#12242 - Improvement of PR FairRootGroup#1244 - see also Issue FairRootGroup#1243 - Solves new sub-case of Cbmroot issue https://redmine.cbm.gsi.de/issues/2620 More generic solution also catching edge case where only Nodes inside assembly are aligned but not assembly itself (cherry picked from commit b4b5f0e)
fuhlig1
pushed a commit
to fuhlig1/FairRoot
that referenced
this pull request
Sep 6, 2023
- cf discussion in root-project/root#12242 - Improvement of PR FairRootGroup#1244 - see also Issue FairRootGroup#1243 - Solves new sub-case of Cbmroot issue https://redmine.cbm.gsi.de/issues/2620 More generic solution also catching edge case where only Nodes inside assembly are aligned but not assembly itself (cherry picked from commit b4b5f0e)
ChristianTackeGSI
pushed a commit
that referenced
this pull request
Nov 16, 2023
- cf discussion in root-project/root#12242 - Improvement of PR #1244 - see also Issue #1243 - Solves new sub-case of Cbmroot issue https://redmine.cbm.gsi.de/issues/2620 More generic solution also catching edge case where only Nodes inside assembly are aligned but not assembly itself (cherry picked from commit b4b5f0e)
ChristianTackeGSI
pushed a commit
that referenced
this pull request
Nov 16, 2023
- cf discussion in root-project/root#12242 - Improvement of PR #1244 - see also Issue #1243 - Solves new sub-case of Cbmroot issue https://redmine.cbm.gsi.de/issues/2620 More generic solution also catching edge case where only Nodes inside assembly are aligned but not assembly itself (cherry picked from commit b4b5f0e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix could be removed once proper fix is done in Root, should not hurt if done twice
Should be backported to the next v18.6.x if accepted as probably needed for next CbmRoot release.
Checklist:
devbranch