Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rbac-manager] updating apiversions for kube 1.19 #385

Merged
merged 3 commits into from
Oct 23, 2020

Conversation

lucasreed
Copy link
Contributor

@lucasreed lucasreed commented Oct 21, 2020

Why This PR?
In kubernetes 1.19, some apiversions will be removed

Fixes #
This change will allow rbac-manager to work in kubernetes 1.19

Changes
Changes proposed in this pull request:

  • change clusterrole, clusterrolebinding to use rbac.authorization.k8s.io/v1
  • change crd to apiVersion apiextensions.k8s.io/v1
  • update crd definition to align with openApiSpec v3 and the kubernetes
    implementation of it
  • added shortnames and singular name for the crd
    • allows the use of kubectl get rbacdef or kubectl get rbd
  • removed Micah as chart owner
  • added myself as chart owner

Checklist:

  • I have updated the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • Any new values have been added to the README for the Chart, or helm-docs has been run for the charts that support it.

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2020

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants