Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Refactor. Remove non-functioning base-path arg from dashboard. #235

Merged
merged 93 commits into from
Dec 22, 2020
Merged

UI Refactor. Remove non-functioning base-path arg from dashboard. #235

merged 93 commits into from
Dec 22, 2020

Conversation

thewildmage
Copy link
Contributor

@thewildmage thewildmage commented Oct 5, 2020 •
edited by sudermanjr
Loading

Closes #234 and closes #43.

Screen shots of new design:

Screen Shot 2020-12-21 at 12 43 40 PM

Screen Shot 2020-12-21 at 12 42 29 PM

Screen Shot 2020-12-21 at 12 44 22 PM

@thewildmage
Update .gitignore
98a3ec3
@thewildmage
clean up head formatting, add meta description
1a0ee6f
@thewildmage
add default language, clean up formatting
e5e2163
@thewildmage
use more semantic html in dashboard and navbar
bd7f475
@thewildmage
remove empty template
d31d354
@thewildmage
indentation tweak
66a5545
@thewildmage
finish removing unused and empty preamble template
a961ae3
@thewildmage
more semantic footer html
c32c29d
@thewildmage
formatting tweaks
c72b568
@thewildmage
replace normalize with modern-css-reset
54e8f7b
@thewildmage
rename font file for clarity
0ac08db
@thewildmage
add utopia fluid type scales
6af99db
@thewildmage
convert namespace_list to more semantic html
f311e47
@thewildmage
start new styling
a4ab0e8
@thewildmage
groundwork for sidebar layout on namespace list page
8e7c0eb
@thewildmage
switch to grid
42ac43e
@thewildmage
iteration on namespace list
beaf288 
adds buttons and gridded namespaces
@thewildmage
sizing and spacing tweaks
bceb160
@thewildmage
style sidebar elements
488c4fd
@thewildmage
class name clean up
666a222
@thewildmage
reflow namespaces list page in narrow window
33d8f9b
@thewildmage
first iteration on search function
6ffa120
@thewildmage
handle multi-word searches and clearing search
2de85a8
@thewildmage
make search submit button work
7336be0
@thewildmage
remove old namespace search script
7def8ab
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thewildmage thewildmage changed the title UI Refresh UI Refactor Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #235 (bfdb800) into master (b23ff56) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   55.21%   55.21%           
=======================================
  Files           8        8           
  Lines         527      527           
=======================================
  Hits          291      291           
  Misses        206      206           
  Partials       30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23ff56...bfdb800. Read the comment docs.

littlelark and others added 18 commits December 20, 2020 21:45
@littlelark
handle all spaces in filtering, not just first one
f7604a4
@littlelark
style namespace list
8634741
@littlelark
make search button look like a button, enable search form to grow to …
45f20f6 
…fill space
@littlelark
simplify namespace list layout
7902cce
@littlelark
simplify usage of list-style: none
d173abd
@littlelark
extract misc css variables, don't scale transform when prefers-reduce…
4a5901e 
…d-motion, tweak namespaces found wording
@littlelark
update handling of no namespaces on namespace list page
7ec1aff
@littlelark
add border around pre elements
35f3aa6
@littlelark
css spaces and formatting adjustments
ce8141c
@littlelark
handle case where namespace has no deployments on detail page
2330dd9
@littlelark
link to specific glossary definitions instead of just QoS
b1b14a5
@littlelark
move all updated css to main.css, remove unused css files
39101a1
@littlelark
fix accessiblity and lighthouse failures
d16af77
@littlelark
switch from 4-space tabs to 2-space tabs in main.css
c606c8e 
to match style used in other files
@littlelark
clean up gohtml formatting, add missing "opens in new window" notices
5e6df01
@littlelark
remove unused javascript
361fc81
@littlelark
more spacing between namespaces in detail
8fa4e4e
remove non-functional base-path. Fix relative linking of static assets
4d85065
@sudermanjr sudermanjr marked this pull request as ready for review December 21, 2020 19:36
@sudermanjr sudermanjr changed the title UI Refactor UI Refactor. Remove non-functioning base-path arg from dashboard. Dec 21, 2020
@sudermanjr sudermanjr merged commit b23fdf1 into FairwindsOps:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasreed lucasreed lucasreed approved these changes

@sudermanjr sudermanjr sudermanjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor UI Add "info" button for QoS types
5 participants
@thewildmage @CLAassistant @lucasreed @sudermanjr @littlelark