Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#236: Add on-by-default option to dashboard #308

Merged
merged 3 commits into from
Apr 7, 2021
Merged

#236: Add on-by-default option to dashboard #308

merged 3 commits into from
Apr 7, 2021

Conversation

isugimpy
Copy link
Contributor

@isugimpy isugimpy commented Apr 5, 2021

This PR aims to fix the issue raised in #236 where namespaces must explicitly be enabled to show up. Noteworthy, I'm not aware of a way to do a LabelSelector with a != value using the map syntax that was already being used in namespace-list.go, so I constructed the selector manually. If there's a more preferred way to handle this, I'm certainly open to updating it. This should be ready to review. I've tested it on a real cluster and it worked as expected.

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #308 (270ea81) into master (e222dbb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   55.21%   55.21%           
=======================================
  Files           8        8           
  Lines         527      527           
=======================================
  Hits          291      291           
  Misses        206      206           
  Partials       30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e222dbb...270ea81. Read the comment docs.

@lucasreed lucasreed linked an issue Apr 7, 2021 that may be closed by this pull request
Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isugimpy Hey thanks a ton, this change LGTM, appreciate you taking the time 🎉

Once tests past after bringing this branch up to date we'll get it merged.

@lucasreed lucasreed merged commit 8d04c6d into FairwindsOps:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace List Incomplete
3 participants