Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner #339

Merged
merged 7 commits into from
Aug 9, 2021
Merged

Add banner #339

merged 7 commits into from
Aug 9, 2021

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Jul 28, 2021

Examples of how this looks below.

Screen Shot 2021-07-28 at 9 24 15 AM

Screen Shot 2021-07-28 at 9 23 57 AM

Screen Shot 2021-07-28 at 9 23 49 AM

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some accessibility and usability suggestions inline.

pkg/dashboard/assets/css/main.css Outdated Show resolved Hide resolved
pkg/dashboard/templates/dashboard.gohtml Outdated Show resolved Hide resolved
pkg/dashboard/templates/namespace_list.gohtml Outdated Show resolved Hide resolved
rbren and others added 3 commits August 5, 2021 09:31
Co-authored-by: Andrew Suderman <andrew@sudermanjr.com>
Co-authored-by: Andrew Suderman <andrew@sudermanjr.com>
Co-authored-by: Andrew Suderman <andrew@sudermanjr.com>
@rbren
Copy link
Contributor Author

rbren commented Aug 5, 2021

Done!

@sudermanjr sudermanjr merged commit a4081ec into master Aug 9, 2021
@sudermanjr sudermanjr deleted the rb/banner-2 branch August 9, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants