Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make namespace filter links unique #528

Merged

Conversation

thewildmage
Copy link
Contributor

@thewildmage thewildmage commented Oct 2, 2022

This PR fixes #505.

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

See #505.

What changes did you make?

Made the changes suggested in #505.

What alternative solution should we consider, if any?

Different wording, maybe? This change is pretty straightforward.

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the easy button? LGTM

@sudermanjr sudermanjr enabled auto-merge (squash) October 2, 2022 00:15
@sudermanjr sudermanjr merged commit b5b7f56 into FairwindsOps:master Oct 2, 2022
@thewildmage thewildmage deleted the thewildmage/unique-namespace-links branch October 2, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"View only this namespace" links should be unique
2 participants