-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INSIGHTS-226 - Insights Admission Requests security issue for rogue Pods #949
Conversation
Fairwinds Insights - Auto-scan job has failed ❌View the full report at insights.fairwinds.com. Show Logs
|
Fairwinds Insights - Auto-scan job has failed ❌View the full report at insights.fairwinds.com. Show Logs
|
Fairwinds Insights Scan ResultsView the full report at insights.fairwinds.com. ✅ No new Action Items detected! |
Fairwinds Insights - Auto-scan job has failed ❌View the full report at insights.fairwinds.com. Show Logs
|
Fairwinds Insights - Auto-scan job has failed ❌View the full report at insights.fairwinds.com. Show Logs
|
Fairwinds Insights - Auto-scan job has failed ❌View the full report at insights.fairwinds.com. Show Logs
|
Fairwinds Insights - Auto-scan job has failed ❌View the full report at insights.fairwinds.com. Show Logs
|
Fairwinds Insights - Auto-scan job has failed ❌View the full report at insights.fairwinds.com. Show Logs
|
…ns into js/NakedPods
Fairwinds Insights - Auto-scan job has failed ❌View the full report at insights.fairwinds.com. Show Logs
|
logrus.Infof("Object has an owner - skipping") | ||
return true, nil, nil, nil | ||
if ownerReferences, ok := decoded["metadata"].(map[string]any)["ownerReferences"].([]any); ok && len(ownerReferences) > 0 { | ||
ownerReference := ownerReferences[0].(map[string]any) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't all owner references be checked for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably there is only one, but this may be a good idea to test all in the case someone tries to bypass the validation
Fairwinds Insights - Auto-scan job has failed ❌View the full report at insights.fairwinds.com. Show Logs
|
Fairwinds Insights - Auto-scan job has failed ❌View the full report at insights.fairwinds.com. Show Logs
|
…ods (#949) * INSIGHTS-226 Insights Admission Requests security issue for naked Pods * INSIGHTS-226 Insights Admission Requests security issue for naked Pods * INSIGHTS-226 Insights Admission Requests security issue for naked Pods * INSIGHTS-226 Insights Admission Requests security issue for naked Pods * Reverted change * Debugging * Code cleanup * Code cleanup * Code cleanup * Code cleanup * Code cleanup * Code cleanup * Code cleanup * Code cleanup * Code cleanup * Code cleanup * Code cleanup * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Fixed bug * Code cleanup * Code cleanup * Adding tests * Removed unused code * Removed unused code * Removed unused code * Removed unused code * Removed unused code * Refactoring * Refactoring * Adding full spec validation * Adding full spec validation * Adding full spec validation * Adding full spec validation * Checking fixing vuln * Checking fixing vuln * Updated validation lib * Updated validation lib * Removed unused code * Changed versopm * Code cleanup * Code cleanup * Code cleanup * Code cleanup * Iterating over owners * Iterating over owners
This PR fixes #
Checklist
Description
What's the goal of this PR?
What changes did you make?
What alternative solution should we consider, if any?
Internal Ticket INSIGHTS-226