Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect-helm and multiple uses of the same chart #67

Closed
lucasreed opened this issue Apr 22, 2020 · 1 comment · Fixed by #69
Closed

detect-helm and multiple uses of the same chart #67

lucasreed opened this issue Apr 22, 2020 · 1 comment · Fixed by #69
Assignees
Labels
enhancement Adding additional functionality or improvements

Comments

@lucasreed
Copy link
Contributor

When multiple releases are from the same chart, I think we should only show one instance of that output.

for example, if helm ls shows this:

NAME                                        	REVISION	UPDATED                 	STATUS  	CHART                              	APP VERSION	NAMESPACE
app-develop                                 	5       	Tue Apr 21 04:13:25 2020	DEPLOYED	app-1                           	1.0        	develop
app-qa                                       	5        	Tue Apr 21 04:13:25 2020	DEPLOYED	app-1                           	1.0        	qa

We should only output a single line for any deprecations found in that chart. This may be easier if we end up pulling in chart name data with #31

@lucasreed
Copy link
Contributor Author

We decided limiting this output would be a disservice to the user. We should report all deprecation/removal(s) we find even if the chart name + version match. Not everyone iterates on their chart version number (for SHAME!) so we could potentially hide issues if we only print out a problem with a chart and not every release of the chart.

sudermanjr pushed a commit that referenced this issue Apr 29, 2020
… name output for helm (#67) (#69)

* should not show duplicate deployed releases and adds release name to output for helm

* fixing e2e tests

* another try at fixing e2e testing expected output format

* adding back spacing at end to see if e2e runs successfully

* removing debug log line

* removing extra space from e2e tests

* Update pkg/helm/helm.go

Co-Authored-By: Andrew Suderman <andrew@sudermanjr.com>

* deleting hostpath-provisioner helm chart which is throwing off spacing in e2e

* Trying a new codecov yaml

* break out marshal functionality a bit more

Co-authored-by: Andrew Suderman <andrew@sudermanjr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements
Projects
None yet
2 participants