Fail on compiler errors #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fail on errors and warnings (except level 4) * include assembly references by name (easier to fix errors) * build class library (instead of console app, so Main isn't needed)
bgrainger
reviewed
Jan 4, 2019
| }; | ||
|
|
||
| private static readonly IReadOnlyList<MetadataReference> s_metadataReferences = s_assemblyReferences | ||
| .Select(x => (MetadataReference) MetadataReference.CreateFromFile(Assembly.Load(x).Location)).ToList(); |
There was a problem hiding this comment.
Nitpick: move these to the end of the class if we're rewriting them anyway.
bgrainger
reviewed
Jan 4, 2019
| @@ -58,7 +69,10 @@ protected static Diagnostic[] GetSortedDiagnosticsFromDocuments(DiagnosticAnalyz | |||
| var diagnostics = new List<Diagnostic>(); | |||
| foreach (var project in projects) | |||
| { | |||
| var compilationWithAnalyzers = project.GetCompilationAsync().Result.WithAnalyzers(ImmutableArray.Create(analyzer)); | |||
| var compilation = project.GetCompilationAsync().Result; | |||
There was a problem hiding this comment.
Pre-existing bug, but should prefer .GetAwaiter().GetResult().
bgrainger
reviewed
Jan 4, 2019
| .AddMetadataReference(projectId, CSharpSymbolsReference) | ||
| .AddMetadataReference(projectId, CodeAnalysisReference); | ||
| .WithProjectCompilationOptions(projectId, new CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary)) | ||
| .AddMetadataReferences(projectId, s_metadataReferences); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes, but, most importantly, fails on compiler errors (and fixes them). Bradley helped.