Use GitHub actions for CI #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaslevesque
force-pushed
the
use-github-actions-for-ci
branch
2 times, most recently
from
95a2c9b
to
e5eaee3
Compare
thomaslevesque
force-pushed
the
use-github-actions-for-ci
branch
from
fa5b08a
to
d157c25
Compare
blairconrad
requested changes
Dec 4, 2022
| @@ -8,7 +8,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution | |||
| .gitattributes = .gitattributes | |||
| .gitignore = .gitignore | |||
| .mailmap = .mailmap | |||
| appveyor.yml = appveyor.yml | |||
There was a problem hiding this comment.
because I forgot! Also didn't do it in FakeItEasy...
There was a problem hiding this comment.
I'm forever forgetting to add files to the sln. More trouble than it's worth, I sometimes think.
No, I didn't look into it yet |
thomaslevesque
force-pushed
the
use-github-actions-for-ci
branch
from
aee48b4
to
110bb9d
Compare
thomaslevesque
force-pushed
the
use-github-actions-for-ci
branch
from
110bb9d
to
08cfb0f
Compare
|
This change has been released as part of FakeItEasy.Analyzers 6.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the same as FakeItEasy/FakeItEasy#1892, with the same commit structure.
I also included the same fixes as in FakeItEasy/FakeItEasy#1895, and I updated FakeItEasy.Analyzers.Build to .NET 6 (so that we don't need .NET 5, and for consistency with FakeItEasy)
As mentioned in the chat, I also had to install .NET Core 2.1 on Windows. No idea why it wasn't necessary in FakeItEasy.
I updated how_to_build.md with the same changes as in FakeItEasy, but I noticed it's outdated. We'll need to update the build instructions, but I didn't want to do it in this PR.
Also, the AppVeyor build is failing, because we use an old VM image (VS 2019) which doesn't have .NET 6. But it's OK, since we're going to remove AppVeyor anyway...