Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for CI #1892

Merged

Conversation

thomaslevesque
Copy link
Member

@thomaslevesque thomaslevesque commented Nov 26, 2022

No description provided.

@thomaslevesque thomaslevesque force-pushed the use-github-actions-for-ci branch 5 times, most recently from 8d5dbc3 to a3f5291 Compare November 27, 2022 03:46
@blairconrad blairconrad force-pushed the use-github-actions-for-ci branch 2 times, most recently from a3f5291 to 1db1f00 Compare November 27, 2022 14:49
@thomaslevesque thomaslevesque force-pushed the use-github-actions-for-ci branch 10 times, most recently from 2f0fadb to 0ee38bf Compare November 28, 2022 05:05
Copy link
Member

@blairconrad blairconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm content to merge once we remove AppVeyor requirement and rename.
Also, we probably want to merge the Tools changes first? I think the deployment script change from #1895 can wait until after this, no?

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@blairconrad
Copy link
Member

  • update required build events

@thomaslevesque thomaslevesque changed the title [WIP] Use GitHub Actions for CI Use GitHub Actions for CI Nov 28, 2022
Copy link
Member

@blairconrad blairconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, except for the docs (and how to build, where we should probably mention the build.ps1.

.github/workflows/ci.yml Show resolved Hide resolved
Copy link
Member

@blairconrad blairconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @thomaslevesque. Great work!

build.cmd = build.cmd
build.sh = build.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@github-actions
Copy link

This change has been released as part of FakeItEasy 7.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants