Fix pack build target to support spaces in path #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't merge! Due to test failures. We've painted ourselves into a corner. |
Yeah, I know... No rush merging this anyway, it's only an issue for me locally, and I can work around it. |
thomaslevesque
force-pushed
the
fix-pack-build-target
branch
from
287a65d
to
2795bf8
Compare
blairconrad
approved these changes
Nov 28, 2022
|
Thanks, @thomaslevesque! I'm sure this will greatly benefit space-having Rider-users. |
|
This change has been released as part of FakeItEasy 7.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
packtarget was failing because I have a space in the path to the repo. Adding double-quotes fixes the problem.