Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Enable no_superfluous_phpdoc_tags fixer #199

Merged
merged 3 commits into from
Dec 21, 2020
Merged

Enhancement: Enable no_superfluous_phpdoc_tags fixer #199

merged 3 commits into from
Dec 21, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 21, 2020 •
edited
Loading

This PR

  • enables the no_superfluous_phpdoc_tags fixer
  • runs make cs
  • runs make baseline

Follows #157.

💁‍♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v2.17.2/doc/rules/phpdoc/no_superfluous_phpdoc_tags.rst.

@localheinz localheinz added the enhancement New feature or request label Dec 21, 2020
@localheinz localheinz self-assigned this Dec 21, 2020
@localheinz localheinz removed their assignment Dec 21, 2020
@localheinz localheinz marked this pull request as ready for review December 21, 2020 14:56
Nyholm
Nyholm approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes please

@Nyholm
Copy link
Member

Nyholm commented Dec 21, 2020

Could you update the psalm baseline?

@localheinz localheinz merged commit c65e3b6 into FakerPHP:main Dec 21, 2020
@localheinz
Copy link
Member Author

Thank you, @Nyholm!

@localheinz localheinz deleted the feature/no-superfluous-phpdoc-tags branch December 21, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @Nyholm