Added barcode extension to core #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimjansen
requested changes
Jan 7, 2021
src/Faker/Core/Barcode.php
Outdated
| { | ||
| $code = Extension\Helper::numerify(str_repeat('#', $length - 1)); | ||
|
|
||
| return $code . \Faker\Calculator\Ean::checksum($code); |
There was a problem hiding this comment.
I maybe would have done this with sprintf to keep it more readable and a bit more secure overall.
|
Thanks! Left some small comments but overall it looks good to me 👍 |
|
^^ Wrong button sorry |
pimjansen
approved these changes
Jan 7, 2021
|
Thanks |
|
Thanks @pimjansen! |
krsriq
added a commit
to krsriq/Faker
that referenced
this pull request
Jan 7, 2021
* add barcode to core * add barcode to core
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Barcode extension is not yet in core.
Author's checklist
Summary of changes
Like #232 only for barcodes - added barcode extension to core.
Review checklist