Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is_IS Address docbock type #438

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Fix is_IS Address docbock type #438

merged 2 commits into from
Jan 27, 2022

Conversation

krsriq
Copy link

@krsriq krsriq commented Jan 27, 2022

What is the reason for this PR?

is_IS\Address::$postcode has the nonexistent type Icelandic.

  • A new feature
  • Fixed an issue (resolve #ID)

Author's checklist

Summary of changes

Fixed the type to array.

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@pimjansen pimjansen merged commit 1a208b4 into FakerPHP:main Jan 27, 2022
@krsriq
Copy link
Author

krsriq commented Jan 27, 2022

Thanks!

@krsriq krsriq deleted the BUGFIX/is_address_postcode branch January 27, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimjansen pimjansen pimjansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krsriq @pimjansen