Removed UUID from Generator to be able to extend it #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also makes #436 obsolete |
pimjansen
force-pushed
the
feature/removed-uuid-from-generator
branch
2 times, most recently
from
ff470f1
to
bf6fb42
Compare
4 tasks
|
Can you add an ignore for this to the bc-roave config? |
pimjansen
force-pushed
the
feature/removed-uuid-from-generator
branch
from
bf6fb42
to
23f16bc
Compare
|
@bram-pkg done! |
bram-pkg
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Reverts the addition of the UUID method to the generator
Author's checklist
Summary of changes
Since the method exists directly on the generator the
addProvidermethod is not able to extend these calls anymore. There we revert it for now and ensure that on v2 these methods used. For v2 we can overwrite it with the container builder however at this moment these are still experimental.Review checklist