-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #1
base: main
Are you sure you want to change the base?
Conversation
**Description**: Specifying the falkordb/falkordb:4.0.0-alpha.1 version of the docker container resolves the `redis.exceptions.ResponseError` specifically mentioning an "Unknown function `vector32f`". **Issue**: Presumably, the falkordb/falkordb:edge (or :latest) version(s) do not support the updated vector search index. **Dependencies**: None.
WalkthroughThe update to FalkorDB's README.md involves adjusting the Docker run command by adding extra port mapping to support version Changes
Possibly related issues
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
**Description**: Specifying the falkordb/falkordb:4.0.0-alpha.1 version of the docker container resolves the `redis.exceptions.ResponseError` specifically mentioning an "Unknown function `vector32f`". **Issue**: Presumably, the falkordb/falkordb:edge (or :latest) version(s) do not support the updated vector search index. **Dependencies**: None.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
README.md
Outdated
@@ -3,7 +3,7 @@ | |||
## Step 1 - Run FalkorDB server | |||
|
|||
``` | |||
docker run -p 6379:6379 -it --rm falkordb/falkordb:edge | |||
docker run -it -p 6379:6379 -p 7687:7687 falkordb/falkordb:4.0.0-alpha.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the Docker run command includes a language specifier for the code block to enhance readability and syntax highlighting in markdown.
- ```
+ ```bash
docker run -it -p 6379:6379 -p 7687:7687 falkordb/falkordb:4.0.0-alpha.1
Description: Specifying the falkordb/falkordb:4.0.0-alpha.1 version of the docker container resolves the redis.exceptions.ResponseError specifically mentioning an "Unknown function vector32f". Issue: Presumably, the falkordb/falkordb:edge (or :latest) version(s) do not support the updated vector search index. Dependencies: None.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
README.md
Outdated
@@ -3,7 +3,7 @@ | |||
## Step 1 - Run FalkorDB server | |||
|
|||
``` | |||
docker run -p 6379:6379 -it --rm falkordb/falkordb:edge | |||
docker run -it -p 6379:6379 falkordb/falkordb:4.0.0-alpha.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the Docker run command to include the language specifier for the code block to enhance readability and syntax highlighting in markdown.
- ```
+ ```bash
docker run -it -p 6379:6379 falkordb/falkordb:4.0.0-alpha.1
vector32f was changed to vec32f you can still use edge |
Thanks, Avi! I'll look into modifying the respective code in this repo to interface with vec32f, if necessary. |
Hi @AviAvni, so I attempted to change all instances of |
Hi @rmeinzer-copado, I've just pushed an update to the Python demo, it uses the latest |
Bingo! Thanks, Roi - works like a charm. |
Description:
Specifying the falkordb/falkordb:4.0.0-alpha.1 version of the docker container resolves the
redis.exceptions.ResponseError
specifically mentioning an "Unknown functionvector32f
".Issue:
Presumably, the falkordb/falkordb:edge (or :latest) version(s) do not support the updated vector search index.
Dependencies:
None.
Summary by CodeRabbit
4.0.0-alpha.1
.