Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

rmeinzer-copado
Copy link

@rmeinzer-copado rmeinzer-copado commented Apr 12, 2024

Description:
Specifying the falkordb/falkordb:4.0.0-alpha.1 version of the docker container resolves the redis.exceptions.ResponseError specifically mentioning an "Unknown function vector32f".

Issue:
Presumably, the falkordb/falkordb:edge (or :latest) version(s) do not support the updated vector search index.

Dependencies:
None.

Summary by CodeRabbit

  • Documentation
    • Updated the Docker run command instructions for FalkorDB server to support new port configurations in version 4.0.0-alpha.1.

**Description**:
Specifying the falkordb/falkordb:4.0.0-alpha.1 version of the docker container resolves the `redis.exceptions.ResponseError` specifically mentioning an "Unknown function `vector32f`".

**Issue**:
Presumably, the falkordb/falkordb:edge (or :latest) version(s) do not support the updated vector search index. 

**Dependencies**:
None.
Copy link

coderabbitai bot commented Apr 12, 2024

Walkthrough

The update to FalkorDB's README.md involves adjusting the Docker run command by adding extra port mapping to support version 4.0.0-alpha.1. This change aims to improve user experience by keeping the documentation aligned with the latest software features.

Changes

File Change Summary
README.md Updated Docker run command to include additional port mapping for FalkorDB server version 4.0.0-alpha.1.

Possibly related issues

Poem

🐰🌟
In the lands of code and byte,
A Docker command was set just right.
Ports aligned, the server's light,
FalkorDB shines, oh what a sight!
Celebrate the change, take flight! 🚀
🌟🐰


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f86c684 and a709444.
Files selected for processing (1)
  • README.md (1 hunks)
Additional comments not posted (2)
README.md (2)

6-6: Ensure the Docker run command includes a language specifier for the code block to enhance readability and syntax highlighting in markdown.


6-6: The Docker run command correctly specifies the falkordb/falkordb:4.0.0-alpha.1 version to address the compatibility issue. Good job on ensuring the correct version is used.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

**Description**:
Specifying the falkordb/falkordb:4.0.0-alpha.1 version of the docker container resolves the `redis.exceptions.ResponseError` specifically mentioning an "Unknown function `vector32f`".

**Issue**:
Presumably, the falkordb/falkordb:edge (or :latest) version(s) do not support the updated vector search index. 

**Dependencies**:
None.
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

README.md Outdated
@@ -3,7 +3,7 @@
## Step 1 - Run FalkorDB server

```
docker run -p 6379:6379 -it --rm falkordb/falkordb:edge
docker run -it -p 6379:6379 -p 7687:7687 falkordb/falkordb:4.0.0-alpha.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the Docker run command includes a language specifier for the code block to enhance readability and syntax highlighting in markdown.

- ```
+ ```bash
docker run -it -p 6379:6379 -p 7687:7687 falkordb/falkordb:4.0.0-alpha.1

Description:
Specifying the falkordb/falkordb:4.0.0-alpha.1 version of the docker container resolves the redis.exceptions.ResponseError specifically mentioning an "Unknown function vector32f".

Issue:
Presumably, the falkordb/falkordb:edge (or :latest) version(s) do not support the updated vector search index.

Dependencies:
None.
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

README.md Outdated
@@ -3,7 +3,7 @@
## Step 1 - Run FalkorDB server

```
docker run -p 6379:6379 -it --rm falkordb/falkordb:edge
docker run -it -p 6379:6379 falkordb/falkordb:4.0.0-alpha.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the Docker run command to include the language specifier for the code block to enhance readability and syntax highlighting in markdown.

- ```
+ ```bash
docker run -it -p 6379:6379 falkordb/falkordb:4.0.0-alpha.1

@gkorland gkorland requested a review from swilly22 April 13, 2024 15:49
@AviAvni
Copy link

AviAvni commented Apr 14, 2024

vector32f was changed to vec32f you can still use edge

@rmeinzer-copado
Copy link
Author

vec32f

Thanks, Avi! I'll look into modifying the respective code in this repo to interface with vec32f, if necessary.

@rmeinzer-copado
Copy link
Author

rmeinzer-copado commented Apr 16, 2024

vector32f was changed to vec32f you can still use edge

Hi @AviAvni, so I attempted to change all instances of vector32f to vec32f in the vectordemo.py file, however, I still get the same error as reported herein. I'd appreciate your specific advice on resolving this error and running this file.

@swilly22
Copy link
Contributor

Hi @rmeinzer-copado, I've just pushed an update to the Python demo, it uses the latest FalkorDB Python API.
Please let me know if you're able to run it.

@rmeinzer-copado
Copy link
Author

Hi @rmeinzer-copado, I've just pushed an update to the Python demo, it uses the latest FalkorDB Python API. Please let me know if you're able to run it.

Bingo! Thanks, Roi - works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants