Implement requestInterval middleware; close #30 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@misbach Let me handle the merge, if you approve. I'd like to resolve the conflicts. |
|
I like it! Go ahead and merge. I'm curious... Is the requestInterval only read once at instantiation time? Or could you change it on the fly later on and have it take affect? |
|
@misbach As implemented it's just read once. I could allow it to be changed on the fly but I don't really want to. Do you imagine developers would want to change that value? |
|
@justincy I was just curious. Leave it the way it is. |
misbach
approved these changes
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible implementation for #30. Is this what you were looking for?