Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live browser reloads? #9

Open
JeremySaks opened this issue May 23, 2015 · 19 comments
Open

Live browser reloads? #9

JeremySaks opened this issue May 23, 2015 · 19 comments
Labels

Comments

@JeremySaks
Copy link

After famous create testproject cd/testproject and famous dev the famous seed project loads as expected but no changes in src/index.js are live reloaded to the browser. In fact they are not reloaded after reloading the browser page. I can comment out the whole file without changes picked up.

The changes are only picked up once I shut down the server and restart with famous dev.

Am I missing something obvious here? I'm on OS X Yosemite and Chrome (also checked Firefox). No errors in the console.

@MylesBorins
Copy link
Contributor

The changes should be refelcted, but we do not have live reload enable. We'll be digging into this,

@wgester
Copy link
Contributor

wgester commented Jun 4, 2015

@JeremySaks Are you still seeing this issue? We've decided against enabling live reload by default, it might be a future flagged option, but for now there's a watch task which should be working.

@JeremySaks
Copy link
Author

@wgester I'm still seeing the issue. I updated to 0.2.10 and added a fresh starter project with famous create. Changes to src/index.js are not picked up after a browser refresh.

@MylesBorins
Copy link
Contributor

Have you turned off caching in the browser?
On Jun 4, 2015 9:31 AM, "Jeremy Saks" notifications@github.com wrote:

@wgester https://github.com/wgester I'm still seeing the issue. I
updated to 0.2.10 and added a fresh starter project with famous create.
Changes to src/index.js are not picked up after a browser refresh.


Reply to this email directly or view it on GitHub
#9 (comment).

@JeremySaks
Copy link
Author

I have not. Is that something I ought to be doing? I don't see an entry for localhost:1618 in chrome://appcache-internals/

@MylesBorins
Copy link
Contributor

In the developer tools you will want to click the gear in the top left
corner and click the check box next to 'disable cache'

If you have trouble I'll follow up with a photo when I'm by my computer
On Jun 4, 2015 9:37 AM, "Jeremy Saks" notifications@github.com wrote:

I have not. Is that something I ought to be doing? I don't see an entry
for localhost:1618 in chrome://appcache-internals/


Reply to this email directly or view it on GitHub
#9 (comment).

@JeremySaks
Copy link
Author

It doesn't appear to have helped. I've checked off 'Disable cache' but updates are not being picked up.

@MylesBorins
Copy link
Contributor

and you are manually hitting refresh? there is no live reload

@JeremySaks
Copy link
Author

Yes, just hitting the browser refresh button. As well as closing and opening new tabs.

@MylesBorins
Copy link
Contributor

are you seeing anything in your terminal when you change the files?

@JeremySaks
Copy link
Author

Yes, it's doing get requests with each reload. I'm happy to set up a screen share as well if you think it will be of any help to you.

@MylesBorins
Copy link
Contributor

MylesBorins commented Jun 4, 2015 via email

@JeremySaks
Copy link
Author

That I don't see.

@MylesBorins
Copy link
Contributor

that is definitely odd...

can you try rm -rf node_modules then running dev again

@JeremySaks
Copy link
Author

Wait, is there possibly an extended lag between changes to the source files and updates? I am now getting some very anomalous behavior.

I added a console.log(Math.random()); to src/index.js just to test and it is just now being picked up on each reload. I added it a few minutes ago. But when I add another console.log("Testing"); it is not picked up on reloads. Some other small experiments like changing the logo dimensions with .setAbsoluteSize are also not picked up with reloads. So now I'm truly confused.

^^ ok trying the rm from your last message.

@MylesBorins
Copy link
Contributor

The update take a sub second to be picked up� bit it isn�t immediate

@JeremySaks
Copy link
Author

rm -rf node_modules and famous dev has not changed things. in addition most of the file changes don't seem to get picked up even after allowing for some lag.

@wgester
Copy link
Contributor

wgester commented Jun 4, 2015

What OS are you using?

@JeremySaks
Copy link
Author

OS X Yosemite v10.10.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants