Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollView should unblock native scrolling when content is no longer scrollable. #491

Closed
trusktr opened this issue Nov 23, 2014 · 3 comments

Comments

@trusktr
Copy link
Contributor

trusktr commented Nov 23, 2014

For example, when you've scrolled to the bottom of a ScrollView, scrolling should now scroll the outer container which might be non-famous. This becomes tricky with nested Famous ScrollViews. Famous should detect when the outer container of a ScrollView is native, or another Famous ScrollView so it can behave accordingly (be it by event bubbling or whatever mechanism).

The bouncy effect at the end of the scrolling might need to be disabled in certain conditions for this to look nice. For example, flinging a ScrollView can show a bounce when the scroll reaches the end, but at that very moment if the user tries to continue scrolling in the same direction it should not have the elastic effect so that if the outer container is to be scrolled it will work nicely.

@StephanBijzitter
Copy link
Contributor

That'd be nice, yeah!

@trusktr
Copy link
Contributor Author

trusktr commented Dec 5, 2014

Here's a sample of it already working with embedded ScrollViews, thanks to @IjzerenHein: https://github.com/IjzerenHein/famous-flex/blob/master/tutorials/FlexScrollView.md#embedded-scrollview-linking

@MylesBorins
Copy link
Contributor

closing for now as we are not going to implement low priority enhancements. Please feel free to file a PR though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants