Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI/CD for Rust #24

Closed
SetZero opened this issue May 13, 2023 · 1 comment · Fixed by #25 or #26
Closed

Improve CI/CD for Rust #24

SetZero opened this issue May 13, 2023 · 1 comment · Fixed by #25 or #26
Assignees
@SetZero

Comments

@SetZero
Copy link
Collaborator

SetZero commented May 13, 2023

Currently our CI/CD only creates a package in the master branch and there are no checks for PRs.

We want to have basic checks for PRs:

  • Run Clippy
  • Run Rust fmt diff check
  • ???
@SetZero SetZero self-assigned this May 13, 2023
SetZero added a commit that referenced this issue May 13, 2023
@SetZero
GH-24: Add Rust code checks on pull request
4162cad
SetZero added a commit that referenced this issue May 13, 2023
@SetZero
GH-24: Add Rust code checks on pull request
ff8fc2d
SetZero added a commit that referenced this issue May 13, 2023
@SetZero
GH-24: Add Rust code checks on pull request
b7cb616
SetZero added a commit that referenced this issue May 13, 2023
@SetZero
GH-24: Add Rust code checks on pull request
dbe3e7d
SetZero added a commit that referenced this issue May 13, 2023
@SetZero
GH-24: Add Rust code checks on pull request
81586d4
SetZero added a commit that referenced this issue May 13, 2023
@SetZero
GH-24: Add Rust code checks on pull request
89b2a55
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Add Rust code checks on pull request
348a9c9
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Add Rust code checks on pull request
4f95f66
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Add Rust code checks on pull request
ab30d70
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Add Rust code checks on pull request
436951d
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Add Rust code checks on pull request
9cad727
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Add Rust code checks on pull request
d61b3a7
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Fix clippy warnings
1a5189a
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Fix clippy warnings
feacb06
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Fix clippy warnings
fb11282
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Fix clippy warnings
2e846b7
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Fix clippy warnings
8cd8921
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Fix build error for top level async
5ca5f19
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Fix build error for top level async
bdfe2f3
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Add Rust code checks on pull request
9e4adda
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Fix clippy warnings
9e60ae7
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Fix build error for top level async
ffa025f
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Fix release build checks
a6057f1
SetZero added a commit that referenced this issue May 14, 2023
@SetZero
GH-24: Fix release build checks
243c75e
@SetZero
Copy link
Collaborator Author

SetZero commented May 14, 2023

Currently this will only be done for Rust, we will create a follow-up ticket for Typescript linting

@SetZero SetZero closed this as completed May 14, 2023
@SetZero SetZero changed the title Improve CI/CD Improve CI/CD for Rust May 14, 2023
@SetZero SetZero mentioned this issue May 14, 2023
Open
@SetZero SetZero linked a pull request May 14, 2023 that will close this issue
GH-24: Add Rust code checks on pull request #25
Merged
@SetZero SetZero linked a pull request May 14, 2023 that will close this issue
GH-24: Fix release build checks #26
Merged
SetZero added a commit that referenced this issue May 17, 2023
@SetZero
GH-24: Add Rust code checks on pull request
a2a5976
SetZero added a commit that referenced this issue May 17, 2023
@SetZero
GH-24: Fix clippy warnings
ba7644e
SetZero added a commit that referenced this issue May 17, 2023
@SetZero
GH-24: Fix build error for top level async
cba267d
SetZero added a commit that referenced this issue May 17, 2023
@SetZero
GH-24: Fix release build checks
b3c57ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SetZero SetZero

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@SetZero