-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New substate #1066
Merged
Merged
New substate #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabrador
force-pushed
the
petr/new-substate
branch
from
April 4, 2024 08:47
2202545
to
57d5e73
Compare
comment out worldstate Use correct type in test_cases
This change remove uses of world-state cli and its library. Update set reads the initial world state from WorldStateDB which is compressed in its own format. The functions is currently removed in this PR. However, the data type will be change such that the WorldStateDB should contain data in updateset structure instead.
wsodsong
reviewed
Apr 11, 2024
wsodsong
reviewed
Apr 11, 2024
…into petr/new-substate # Conflicts: # cmd/util-db/db/autogen.go # cmd/util-db/db/lachesis-update.go # cmd/util-updateset/updateset/generate.go # cmd/util-worldstate/main.go # cmd/util-worldstate/state/account.go # cmd/util-worldstate/state/clone.go # cmd/util-worldstate/state/compare.go # cmd/util-worldstate/state/dump.go # cmd/util-worldstate/state/evolve.go # cmd/util-worldstate/state/info.go # cmd/util-worldstate/state/root.go # cmd/util-worldstate/state/utils.go # cmd/util-worldstate/version/container.go # cmd/util-worldstate/version/info.go # cmd/util-worldstate/version/info_test.go # utildb/lachesis-update.go # utildb/opera.go # utils/default_config.go # utils/worldstate_update.go # world-state/db/snapshot/account.go # world-state/db/snapshot/account_test.go # world-state/db/snapshot/evolve.go # world-state/db/snapshot/substate.go # world-state/db/snapshot/substate_test.go # world-state/types/account.go
wsodsong
reviewed
Apr 11, 2024
# Conflicts: # cmd/util-db/db/autogen.go # cmd/util-db/db/lachesis-update.go # cmd/util-updateset/updateset/generate.go # executor/extension/primer/primer.go # utildb/lachesis-update.go # utils/default_config.go # utils/statedb_test.go # utils/worldstate_update.go
wsodsong
requested changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve. I only mark this as "Request changes" to block merging until changes in go-ethereum-substate are merged.
# Conflicts: # executor/extension/aidadb/aida_db_manager.go # executor/extension/aidadb/aida_db_manager_test.go # go.mod # go.sum # txcontext/substate/account_test.go # txcontext/substate/newsubstate/account.go # txcontext/substate/newsubstate/block_environment.go # txcontext/substate/newsubstate/substate.go # txcontext/substate/newsubstate/world_state.go # txcontext/substate/receipt.go # txcontext/substate/result.go # txcontext/substate/result_test.go # txcontext/substate/world_state_test.go
# Conflicts: # executor/extension/statedb/temporary_state_prepper.go # go.sum
cabrador
force-pushed
the
petr/new-substate
branch
from
June 11, 2024 05:31
f54a2bf
to
7d18da0
Compare
wsodsong
approved these changes
Jun 11, 2024
HerbertJordan
pushed a commit
that referenced
this pull request
Jun 27, 2024
Apply new substate struct to Aida. --------- Co-authored-by: wsodsong <wasuwee.sodsong@gmail.com> Co-authored-by: Matěj Mlejnek <matej@fantom.foundation> Co-authored-by: ph <ph@fantom.foundation>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses new refactored
Substate
repoType of change