Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

broadcast event test fix #311

Merged
merged 4 commits into from Aug 29, 2019
Merged

broadcast event test fix #311

merged 4 commits into from Aug 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 27, 2019

GetPackInfosMsg could be received before NewEventHashesMsg/EventsMsg in gossip.TestBroadcastEvent().

@quan8
Copy link
Contributor

quan8 commented Aug 28, 2019

  • Move ExpectMsgOneOf in helper_test.go into handler_test.go, as only used in that test.

  • handler_test.go: since the test assumes that "GetPackInfosMsg could be received first". Thus, it'd better to change ExpectMsgOneOf() to handle that, if possible.

  • change sf to ep

devintegral pushed a commit that referenced this pull request Aug 29, 2019
Merge pull request #311 from integraloleg/hotfix/TestBroadcastEvent
@devintegral devintegral merged commit 406e4b5 into Fantom-foundation:scope2 Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants