Allow to break directory scan started from a macro (Mantis#0002692). #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alabuzhev
reviewed
Jun 15, 2023
johnd0e
force-pushed
the
fix-macro-f3-ctrlq
branch
from
669edcf
to
349ecbb
Compare
|
@alabuzhev |
Looks like they updated VS in the build image and something is no longer compatible. |
alabuzhev
reviewed
Jun 17, 2023
alabuzhev
reviewed
Jun 17, 2023
alabuzhev
reviewed
Jun 17, 2023
| while (ScTree.GetNextName(FindData,strFullName)) | ||
| { | ||
| // Mantis#0002692 | ||
| if (!Global->CtrlObject->Macro.IsExecuting()) |
There was a problem hiding this comment.
You can test it yourself.
- Place cursor at some pretty large directory
- Execute
lua:Keys"EnOut F3 F1" - Wait a couple of seconds, then press `Esc´
Note 2 things:- Operation is successfully interrupted
- Help screen appears only after operation is finished (or interrupted), and not immediately, like was in f7ae5b2
johnd0e
force-pushed
the
fix-macro-f3-ctrlq
branch
from
349ecbb
to
356e2ee
Compare
johnd0e
force-pushed
the
fix-macro-f3-ctrlq
branch
2 times, most recently
from
0c189c9
to
7050380
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix by Shmuel: shmuz/far2m#36