Catch SlipLib Exception Per #62 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in Lated Develop Branch For PyPi Installation Fix
Pypi doesn't like v0.0.2a and thinks it's older than v0.0.2 so I need to move to v0.0.3
Changed to v0.0.3 for pypi packaging version operation
Updated to latest pytest 3.4.1 and revved to v0.0.4
…otocolError * It was observed in use that an exception while decoding packets which had SLIP framing errors was not being caught. This commit adds an exception to do so. * Also added some TODO notes for unit testing slip code.
Pull Request Test Coverage Report for Build 58
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in IT #62 which fixes an exception that was uncaught and found during Hardware In The Loop Testing.
sliplib.slip.ProtocolErrorto receive()