feat: analytics referrer attribution spa on main

- Set up analytics behavior for referrer attribution in SPA; - Fix additional issues related to analytics context in tracking events; - Fix inconsistencies in analytics tests.
Farfetch · Jan 29, 2024 · b9d6190 · b9d6190
1 parent 5bb8b29
commit b9d6190
Show file tree

Hide file tree

Showing 13 changed files with 281 additions and 134 deletions.
diff --git a/packages/analytics/src/Analytics.ts b/packages/analytics/src/Analytics.ts
@@ -236,10 +236,10 @@ class Analytics {
    *
    * @returns Promise that will resolve when the method finishes.
    */
-  protected async onLoadedIntegrations(
+  protected onLoadedIntegrations(
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     loadedIntegrations: IntegrationRuntimeData[],
-  ): Promise<void> {
+  ): void | Promise<void> {
     // Do nothing
   }
 
@@ -442,31 +442,29 @@ class Analytics {
     eventContext?: EventContextData,
   ): Promise<this> {
     return await this.trackInternal(
-      TrackType.Track,
-      event,
-      properties,
-      eventContext,
+      await this.getTrackEventData(
+        TrackType.Track,
+        event,
+        properties,
+        eventContext,
+      ),
     );
   }
 
   /**
    * Internal track method used by the public track method. Builds the track object
    * with page default properties on the context.
    *
-   * @param type         - Type of event to be tracked.
-   * @param event        - Name of the event.
-   * @param properties   - Properties of the event.
-   * @param eventContext - Context data that is specific for this event.
+   * @param trackData    - Data for the event.
    *
    * @returns Promise that will resolve with the instance that was used when calling this method to allow
    * chaining.
    */
   protected async trackInternal(
-    type: TrackTypesValues = TrackType.Track,
-    event: string,
-    properties?: EventProperties,
-    eventContext?: EventContextData,
+    trackData: EventData<TrackTypesValues>,
   ): Promise<this> {
+    const { event } = trackData;
+
     if (!this.isReady) {
       logger.error(
         `Analytics tried to track the event ${event} but failed. Did you forget to call "analytics.ready()?"`,
@@ -486,15 +484,8 @@ class Analytics {
     await this.setUserPromise;
 
     try {
-      const data = await this.getTrackEventData(
-        type,
-        event,
-        properties,
-        eventContext,
-      );
-
       this.forEachIntegrationSafe(this.activeIntegrations, integration =>
-        integration.track(data),
+        integration.track(trackData),
       );
     } catch (error) {
       logger.error(

diff --git a/packages/analytics/src/__tests__/__snapshots__/index.test.ts.snap b/packages/analytics/src/__tests__/__snapshots__/index.test.ts.snap
@@ -211,6 +211,7 @@ Object {
     "LAST_FROM_PARAMETER_KEY": "__lastFromParameter",
     "LOAD_INTEGRATION_TRACK_TYPE": "loadIntegration",
     "ON_SET_USER_TRACK_TYPE": "onSetUser",
+    "PAGE_LOCATION_REFERRER_KEY": "pageLocationReferrer",
     "StorageWrapper": [Function],
     "getCheckoutOrderIdentificationProperties": [Function],
     "getCheckoutProperties": [Function],

diff --git a/packages/analytics/src/__tests__/analytics.test.ts b/packages/analytics/src/__tests__/analytics.test.ts
@@ -319,7 +319,10 @@ describe('analytics', () => {
         const spyTrack = jest.spyOn(integrationInstance, 'track');
 
         // @ts-expect-error Forcing call to trackInternal
-        analytics.trackInternal(TrackType.Page, PageType.Homepage);
+        analytics.trackInternal({
+          type: TrackType.Page,
+          event: PageType.Homepage,
+        });
 
         analytics.track('myEvent');
 
@@ -951,7 +954,10 @@ describe('analytics', () => {
           );
 
           // @ts-expect-error
-          await analytics.trackInternal(TrackType.Page, PageType.Homepage);
+          await analytics.trackInternal({
+            type: TrackType.Page,
+            event: PageType.Homepage,
+          });
 
           expect(spyTrack).toHaveBeenCalled();
 

diff --git a/packages/analytics/src/utils/constants.ts b/packages/analytics/src/utils/constants.ts
@@ -25,3 +25,4 @@ export const ANALYTICS_UNIQUE_EVENT_ID = '__blackoutAnalyticsEventId';
 export const ANALYTICS_UNIQUE_VIEW_ID = '__uniqueViewId';
 export const ANALYTICS_PREVIOUS_UNIQUE_VIEW_ID = '__previousUniqueViewId';
 export const LAST_FROM_PARAMETER_KEY = '__lastFromParameter';
+export const PAGE_LOCATION_REFERRER_KEY = 'pageLocationReferrer';
diff --git a/packages/analytics/src/utils/index.ts b/packages/analytics/src/utils/index.ts
@@ -8,6 +8,7 @@ export {
   ANALYTICS_UNIQUE_VIEW_ID,
   ANALYTICS_PREVIOUS_UNIQUE_VIEW_ID,
   LAST_FROM_PARAMETER_KEY,
+  PAGE_LOCATION_REFERRER_KEY,
 } from './constants.js';
 export * from './defaults.js';
 export * from './getters.js';

diff --git a/packages/react/src/__tests__/__snapshots__/index.test.ts.snap b/packages/react/src/__tests__/__snapshots__/index.test.ts.snap
@@ -251,6 +251,7 @@ Object {
     "integrations": Map {},
     "isReady": false,
     "lastFromParameter": null,
+    "lastPageLocation": "",
     "platform": "web",
     "previousUniqueViewId": null,
     "setStoragePromise": Promise {},

diff --git a/packages/react/src/analytics/__tests__/analytics.test.ts b/packages/react/src/analytics/__tests__/analytics.test.ts
@@ -5,6 +5,7 @@ import AnalyticsCore, {
   FromParameterType,
   type IntegrationOptions,
   integrations,
+  PageType,
 } from '@farfetch/blackout-analytics';
 import TestStorage from 'test-storage';
 import type { WebContext } from '../context.js';
@@ -123,10 +124,14 @@ describe('analytics web', () => {
       await analytics.page(event, properties, eventContext);
 
       expect(coreTrackSpy).toHaveBeenCalledWith(
-        analyticsTrackTypes.Page,
-        event,
-        properties,
-        eventContext,
+        expect.objectContaining({
+          type: analyticsTrackTypes.Page,
+          event,
+          properties,
+          context: expect.objectContaining({
+            event: expect.objectContaining(eventContext),
+          }),
+        }),
       );
 
       // Allow the integration to run - this will trigger the flow to track the previously stored page() event
@@ -276,10 +281,130 @@ describe('analytics web', () => {
     await analytics.page(mockEvent, mockEventProperties, mockEventContext);
 
     expect(coreTrackSpy).toHaveBeenCalledWith(
-      analyticsTrackTypes.Page,
-      mockEvent,
-      mockEventProperties,
-      mockEventContext,
+      expect.objectContaining({
+        type: analyticsTrackTypes.Page,
+        event: mockEvent,
+        properties: mockEventProperties,
+        context: expect.objectContaining({
+          event: expect.objectContaining(mockEventContext),
+        }),
+      }),
     );
   });
+
+  describe('Page Location Referrer Property', () => {
+    // The 'page location referrer' property is significant within the analytics context, specifically concerning web pages.
+    // It is essential to ensure, through various tests, that different scenarios verify the proper operation of references,
+    // especially in the case of a Single Page Application (SPA).
+
+    const newAnalyticsIntance = () =>
+      new (analytics.constructor as {
+        new (): typeof analytics;
+      })();
+    // @ts-expect-error
+    const coreTrackSpy = jest.spyOn(AnalyticsCore.prototype, 'trackInternal');
+
+    beforeEach(() => {
+      coreTrackSpy.mockClear();
+    });
+
+    it('Should retrieve pageLocationReferrer value from origin on first page view', async () => {
+      const origin = 'www.example.com';
+
+      jest.spyOn(document, 'referrer', 'get').mockReturnValueOnce(origin);
+
+      const analyticsClean = newAnalyticsIntance();
+
+      await analyticsClean.page(PageType.Homepage);
+
+      expect(coreTrackSpy).toHaveBeenCalledWith(
+        expect.objectContaining({
+          type: analyticsTrackTypes.Page,
+          event: PageType.Homepage,
+          context: expect.objectContaining({
+            web: expect.objectContaining({
+              pageLocationReferrer: origin,
+            }),
+          }),
+        }),
+      );
+    });
+
+    it('Should set `pageLocationReferrer` value to the previous page instead of document.referrer after the first navigation event', async () => {
+      const origin = 'www.example.com';
+
+      jest.spyOn(document, 'referrer', 'get').mockReturnValueOnce(origin);
+      window.location.href = `${origin}/${PageType.Homepage}`;
+
+      const analyticsClean = newAnalyticsIntance();
+
+      await analyticsClean.page(PageType.Homepage);
+
+      expect(coreTrackSpy).toHaveBeenCalledWith(
+        expect.objectContaining({
+          type: analyticsTrackTypes.Page,
+          event: PageType.Homepage,
+          context: expect.objectContaining({
+            web: expect.objectContaining({
+              pageLocationReferrer: origin,
+            }),
+          }),
+        }),
+      );
+
+      // set another page location
+      window.location.href = `${origin}/${PageType.About}`;
+
+      await analyticsClean.page(PageType.About);
+
+      expect(coreTrackSpy).toHaveBeenCalledWith(
+        expect.objectContaining({
+          type: analyticsTrackTypes.Page,
+          event: PageType.About,
+          context: expect.objectContaining({
+            web: expect.objectContaining({
+              pageLocationReferrer: `${origin}/${PageType.Homepage}`,
+            }),
+          }),
+        }),
+      );
+    });
+
+    it('should set `pageLocationReferrer` value to the previous page instead of document.referrer on track actions', async () => {
+      const origin = 'www.example.com';
+
+      jest.spyOn(document, 'referrer', 'get').mockReturnValueOnce(origin);
+      window.location.href = `${origin}/${PageType.Homepage}`;
+
+      const analyticsClean = newAnalyticsIntance();
+
+      await analyticsClean.track(mockEvent, mockEventProperties);
+
+      expect(coreTrackSpy).toHaveBeenCalledWith(
+        expect.objectContaining({
+          type: analyticsTrackTypes.Track,
+          event: mockEvent,
+          context: expect.objectContaining({
+            web: expect.objectContaining({
+              pageLocationReferrer: origin,
+            }),
+          }),
+        }),
+      );
+
+      await analyticsClean.page(PageType.Homepage);
+
+      expect(coreTrackSpy).toHaveBeenCalledWith(
+        expect.objectContaining({
+          type: analyticsTrackTypes.Page,
+          event: PageType.Homepage,
+          context: expect.objectContaining({
+            web: expect.objectContaining({
+              pageLocationReferrer: `${origin}/${PageType.Homepage}`,
+            }),
+          }),
+        }),
+      );
+    });
+  });
 });
diff --git a/packages/react/src/analytics/__tests__/context.test.ts b/packages/react/src/analytics/__tests__/context.test.ts
@@ -15,7 +15,6 @@ describe('context', () => {
           title: document.title,
           referrer: document.referrer,
         },
-        pageLocationReferrer: window.location.href,
       },
     };